Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable/Disable Test Instrumentation #1543

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Enable/Disable Test Instrumentation #1543

merged 1 commit into from
Nov 8, 2023

Conversation

maxep
Copy link
Member

@maxep maxep commented Nov 8, 2023

What and why?

Enable/Disable Test Instrumentation via env.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep requested a review from a team as a code owner November 8, 2023 08:57
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 8, 2023 •
edited
Loading

Datadog Report

Branch report: maxep/fix-nightly
Commit report: 683a176

❄️ dd-sdk-ios: 0 Failed, 2 New Flaky, 2463 Passed, 0 Skipped, 23m 37.24s Wall Time

New Flaky Tests (2)

  • testGivenCompositeDelegate_whenInterceptingRequests_itDetectFirstPartyHost - NetworkInstrumentationFeatureTests - Last Failure

    Expand for error 
     Assertion Failure at NetworkInstrumentationFeatureTests.swift:568: XCTAssertTrue failed

  • testConcurrentBinding - URLSessionDataDelegateSwizzlerTests - Last Failure

    Expand for error 
     Abort trap. Check error.crash_log for the full crash log.

@maxep maxep force-pushed the maxep/fix-nightly branch from 6d6c097 to 683a176 Compare November 8, 2023 09:38
maciejburda
maciejburda approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 🎖️

@maxep maxep merged commit c731605 into develop Nov 8, 2023
8 checks passed
@maxep maxep deleted the maxep/fix-nightly branch November 8, 2023 16:55
@maxep maxep mentioned this pull request Nov 9, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejburda maciejburda maciejburda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxep @maciejburda