Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable Test Instrumentation #1550

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Enable/Disable Test Instrumentation #1550

merged 1 commit into from
Nov 9, 2023

Conversation

maxep
Copy link
Member

@maxep maxep commented Nov 9, 2023

What and why?

Revert #1543 as nightly keeps hanging.

https://app.bitrise.io/build/64401a5f-d2c3-4560-9a2c-492f9d051b6c
https://app.bitrise.io/build/519d7f06-22ea-4a9a-9f45-03864d26a963

Use DD_DISABLE_TEST_INSTRUMENTING to prevent from installing DatadogSDKTesting framework.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep requested a review from a team as a code owner November 9, 2023 10:06
@maxep maxep merged commit ab86bfc into develop Nov 9, 2023
1 check passed
@maxep maxep deleted the maxep/fix-nightly branch November 9, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants