RUM-2816 Session Replay Browser Record Receiver #1720
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 2880 Passed, 0 Skipped, 32m 50.65s Wall Time 🔻 Code Coverage Decreases vs Default Branch (8)
|
maxep
force-pushed
the
maxep/RUM-2816/web-view-sr-receiver
branch
6 times, most recently
from
2ae4f21 to
08e8f24
Compare
maxep
force-pushed
the
maxep/RUM-2816/web-view-sr-receiver
branch
from
d95ca54 to
594b1e9
Compare
maxep
force-pushed
the
maxep/RUM-2816/web-view-sr-receiver
branch
from
594b1e9 to
0242681
Compare
| if let viewID = self.viewCache.lastView(before: date, hasReplay: true) { | ||
| if let viewID = self.viewCache.lastView(before: correctedDate, hasReplay: true) { |
There was a problem hiding this comment.
We should actually use the corrected time so the browser view is associated to the right native view.
| private enum Constants { | ||
| enum Constants { |
There was a problem hiding this comment.
for accessibility in tests.
| internal struct RUMContext: Decodable, Equatable { | ||
| internal struct RUMContext: Codable, Equatable { |
There was a problem hiding this comment.
Adding Encodable for tests.
| static let totalWireframeMutationRecords = 7 | ||
| static let totalWireframeMutationRecords = 5 |
There was a problem hiding this comment.
Reflecting removal of the WKWebView from the unsupported views.
| @@ -40,18 +40,6 @@ internal final class WebViewEventReceiver: FeatureMessageReceiver { | |||
| return false | |||
| } | |||
|
|
|||
| write(event: event, to: core) | |||
There was a problem hiding this comment.
I can see, that change joins two functions. Does it make sense to keep it broken down to two functions? Just for the readability sake.
There was a problem hiding this comment.
Lets keep it as one for now, we can revisit if it grow in complexity!
| return offset | ||
| } | ||
| offsets.insert((id, offset), at: 0) | ||
| // only retain 3 offsets |
There was a problem hiding this comment.
idk.. this is from the original imp of RUM web-view integration #683
What and why?
Forward Browser records to Session Replay pipeline.
How?
The
WebViewRecordReceiverwill get Browser records from the message-bus, apply the NTP offset of the container RUM view and write it to Session Replay storage.Review checklist
Custom CI job configuration (optional)
tools/