Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WebView Replay #1776

Merged
merged 22 commits into from
Apr 26, 2024
Merged

Support WebView Replay #1776

merged 22 commits into from
Apr 26, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Apr 15, 2024 •
edited
Loading

What and why?

Add support for WebView recording in Session Replay

How?

Merge the following PRs to develop:

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

maxep and others added 14 commits March 21, 2024 19:07
@maxep
RUM-2816 WebView Record Receiver
4174d09
@maxep
Update testUnsupportedView()-allowAll-privacy.png.json
1f5b758
@maxep
RUM-2816 Use corrected date
193975f
@maxep
RUM-2816 Apply rum view time offset
0242681
@maxep
Merge pull request #1720 from DataDog/maxep/RUM-2816/web-view-sr-rece…
e25a3bf 
…iver

RUM-2816 Session Replay Browser Record Receiver
@maxep
RUM-2813 Add webview replay configuration
819b4dd
@maxep @ncreated
Apply suggestions from code review
d511735 
Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
@maxep
Apply suggestions from code review
92dc3b0
@maxep
Merge pull request #1754 from DataDog/maxep/RUM-2813/sr-webview-privacy
6c4d5d1 
RUM-2813 Add webview replay configuration
@maxep
RUM-3531 WebView slot cache
d524f2b
@maxep
RUM-3135 Build hidden webview wireframes
6eff630
@maxep
RUM-3531 Use NSHashTable as webview cache
62185d6
@maxep
Merge pull request #1760 from DataDog/maxep/RUM-3531/hide-webview-wir…
d4b1d4a 
…eframe

RUM-3531 WebView slot cache
@maxep
Merge branch 'develop' into feature/webview-replay
cc5692d
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Apr 15, 2024 •
edited
Loading

Datadog Report

Branch report: feature/webview-replay
Commit report: 0930c24
Test service: dd-sdk-ios

✅ 0 Failed, 3068 Passed, 0 Skipped, 27m 50.07s Wall Time
🔻 Test Sessions change in coverage: 5 decreased, 8 increased, 2 no change

🔻 Code Coverage Decreases vs Default Branch (5)

  • test DatadogRUMTests tvOS 80.83% (-0.2%) - Details
  • test DatadogInternalTests tvOS 80.1% (-0.04%) - Details
  • test DatadogTraceTests tvOS 49.52% (-0.03%) - Details
  • test DatadogInternalTests iOS 80.15% (-0.01%) - Details
  • test DatadogTraceTests iOS 49.45% (-0.01%) - Details

@maxep maxep force-pushed the feature/webview-replay branch from 03aeebe to 0134202 Compare April 15, 2024 12:02
@maxep maxep marked this pull request as ready for review April 15, 2024 15:21
@maxep maxep requested review from a team as code owners April 15, 2024 15:21
@maxep maxep marked this pull request as draft April 17, 2024 12:34
@maxep maxep marked this pull request as ready for review April 19, 2024 11:43
maciejburda
maciejburda previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Easy to follow after all the previous PRs to the branch.

Spotted some minor nits

DatadogWebViewTracking/Sources/WebViewTracking.swift Outdated Show resolved Hide resolved
DatadogWebViewTracking/Sources/WebViewTracking.swift Outdated Show resolved Hide resolved
DatadogWebViewTracking/Sources/WebViewTracking.swift Outdated Show resolved Hide resolved
@maxep @maciejburda
Apply suggestions from code review
7ec152f 
Co-authored-by: Maciej Burda <maciej.burda@datadoghq.com>
@maxep maxep requested a review from maciejburda April 19, 2024 12:05
@maxep maxep self-assigned this Apr 19, 2024
maciejburda
maciejburda previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxep maxep requested a review from maciejburda April 25, 2024 08:34
@maxep maxep merged commit c46b9df into develop Apr 26, 2024
20 checks passed
@ganeshnj ganeshnj mentioned this pull request May 2, 2024
Merged
8 tasks
This was referenced May 7, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejburda maciejburda maciejburda approved these changes

Assignees

@maxep maxep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxep @maciejburda