-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-4079 chore: Migrate dogfooding automation to GitLab #1961
RUM-4079 chore: Migrate dogfooding automation to GitLab #1961
Conversation
d47d7b3
to
201b402
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, couple of suggestion to make it robust to internal working of package.resolved file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBC: This script isn't bringing anything new. It's just an extract of the minimal piece from the previous dogfooding model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 great work with quality of life improvements.
What and why?
📦 🧰 This PR migrates Dogfooding automation to GitLab. It comes with multiple quality of life improvements to streamline our dogfooding process:
develop
directly.sdk_version
will now ponit to dogfooded version (e.g.2.14.1+f3024dc4
).It follows other GitLab migration efforts: #1957, #1953, #1945, #1921 and #1910. With this merge, there will be no other meaningful automations remaining in Bitrise.
How?
Dogfooding is a new GitLab stage, which can be started manually for
develop
commits:The previous
dogfood.py
(Python) automation has been replaced withmake
+dogfood.sh
:make dogfood-shopist
make dogfood-datadog-app
There are two Python scripts called by
dogfood.sh
:update-dependency.py
- updatesPackage.resolved
in dependant project.read-dogfooded-hash.py
- reads last dogfooded commit from dependant project to generate changelog.Same as before, the dogfooding process is:
Package.resolved
in dependant projectdogfooding-<dogfooded commit>
branch🎁 New things
We're now dogfooding from
develop
branch directly, meaning no more merges required todogfooding
branch. Thedogfooding
can be deleted after we make sure dependant projects no longer need it.Each PR opened to dependant repo will now include CHANGELOG that lists all PRs merged to
dd-sdk-ios
since previous dogfooding. See these test PRs:The
sdk_version
in dependant projects is now updated to include dogfooded commit hash. This will tell us exactly which SDK version is being used:^ after round of feedback, this is now using
+
instead of-
to conform with https://semver.org/In order to make it all work, these two PRs to dependant repos must be merged before we start using it:
Review checklist