Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4079 chore: Do not block CI pipeline with dogfooding jobs #1965

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Jul 22, 2024

What and why?

📦 Fixes the problem of blocking CI pipeline for develop when manual Dogfooding jobs are added (since #1961).

Expected behaviorus are:

  • The develop pipeline is not blocked by awaiting manual jobs to be ran.
  • The failures of Dogfooding jobs should not alter the state of develop commit integration (such should be only determined from default integration stages like tests, ui-tests and smoke-tests).

How?

Using rules:allow_failure:true:

Use allow_failure: true in rules to allow a job to fail without stopping the pipeline.

You can also use allow_failure: true with a manual job. The pipeline continues running without waiting for the result of the manual job.

Without customizing allow_failure, the pipeline uses default (false), which was causing the whole pipeline to wait:

allow_failure: false combined with when: manual in rules causes the pipeline to wait for the manual job to run before continuing.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@ncreated ncreated self-assigned this Jul 22, 2024
@ncreated ncreated marked this pull request as ready for review July 22, 2024 07:42
@ncreated ncreated requested review from a team as code owners July 22, 2024 07:42
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ncreated ncreated merged commit 05e1e8e into develop Jul 22, 2024
17 checks passed
@ncreated ncreated deleted the ncreated/RUM-4079/do-not-block-ci-with-dgf-job branch July 22, 2024 08:13
@ncreated ncreated mentioned this pull request Jul 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants