RUMM-1925 Add @service attribute to all RUM events
#725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to unify it with `dd-sdk-android` and with Browser SDK events.
ncreated
deleted the
ncreated/RUMM-1925-add-service-attribute-to-to-all-RUM-events
branch
This was referenced Jan 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR adds
@serviceattribute to all RUM events. This is to unify iOS events with Browser SDK and Android SDK.How?
serviceis already resolved byFeaturesConfiguration.Common. This PR only passes it all the way down to RUM scopes thru existing DI container.Review checklist