-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-1911 Combined merge of WebView tracking #729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HostsSanitizer refactored out and shared
…Bridge RUMM-1785 DatadogEventBridge implemented
Optionals to non-optionals, non-optionals to optionals ashes to ashes, dust to dust...
WKUserContentController_DatadogTests improved
WebRUMEvents are decorated as raw JSONs instead of serializing them into RUMDataModels
Missing test case added: sampled out native session
RUMM-1791 WebEventConsumers added
RUMWebViewCommand is an empty command that keeps the session alive
…entCommand RUMM-1793 WebView events fire RUMWebViewCommand
hybrid-application: merge from master
It was in ns and that resulted in dropped events
…event-date RUMM-1649 Fix: WebRUMEvent date offset in Ms
source property added to common_schema.json
WebViewScenarioTest uses an actual website to test WebView Tracking feature
…ng test plan this is done by switching crash reporting `.xctestplan` to not include new tests automatically and removing Webviews test from the existing list.
…-apps-with-master RUMM-1649 Update `hybrid-application` branch with `master`
as this is now possible for Browser SDK views.
sent from Browser SDK.
- so logs can be properly digested and processed by BE.
…ot all events within our tests.
…tests RUMM-1649 WebViewTracking integration test added
…webview-logs-being-not-sent-properly RUMM-1924 Fix bug with WebView logs not appearing in Logs Explorer
to unify it with `dd-sdk-android` and with Browser SDK events.
…ile no view is active as this scenario is very likely to happen when tracking WebViews and it doesn't indicate user mistake.
…console-being-spammed-on-every-webview-event RUMM-1926 Do not print warning when receiving 'keep alive' command in WebView tracking
…ttribute-to-to-all-RUM-events RUMM-1925 Add `@service` attribute to all RUM events
…L_APIS` compiler flag to not expose it in releases until validated. It will be still available in dogfood projects.
…SDK events - now possible after DataDog/browser-sdk#1271
…ew-tracking-for-dogfooding RUMM-1911 Prepare WebView tracking for dogfooding
maxep
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed in sub-PRs! GTG 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This is combined merge of WebView tracking feature to the main branch. The feature is disabled in public API with
DD_SDK_ENABLE_EXPERIMENTAL_APIS
flag.WebViews tracking is complete enough to merge it to
master
and start dogfooding.How?
Only merging
feature/hybrid-application
→master
, this includes:@service
attribute to all RUM events #725Review checklist