RUMM-1911 Prepare WebView tracking for dogfooding #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L_APIS` compiler flag to not expose it in releases until validated. It will be still available in dogfood projects.
…SDK events - now possible after DataDog/browser-sdk#1271
ncreated
commented
Jan 19, 2022
| } | ||
| XCTAssertGreaterThan(browserView.resourceEvents.count, 0, "It should track some Webview resources") | ||
| browserView.resourceEvents.forEach { browserResourceEvent in | ||
| XCTAssertEqual(browserResourceEvent.application.id, expectedBrowserRUMApplicationID, "Webview events should use iOS SDK application ID") | ||
| XCTAssertEqual(browserResourceEvent.session.id, expectedBrowserSessionID, "Webview events should use iOS SDK session ID") | ||
| XCTAssertEqual(browserResourceEvent.service, expectedBrowserServiceName, "Webview events should use Browser SDK `service`") | ||
| XCTAssertNotEqual(browserResourceEvent.source, .ios, "Webview events should use Browser SDK `source`") | ||
| XCTAssertEqual(browserResourceEvent.source, .browser, "Webview events should use Browser SDK `source`") |
There was a problem hiding this comment.
This is now possible after DataDog/browser-sdk#1271 - it was nil before.
ncreated
deleted the
ncreated/RUMM-1911-prepare-webview-tracking-for-dogfooding
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR adds last changes to
hybrid-applicationbranch to prepare it for dogfooding.How?
TODOs;Additionally, it hides the entry code to WebView tracking behind
DD_SDK_ENABLE_EXPERIMENTAL_APIScompiler flag. We used this feature flag successfully to disable Crash Reporting in #487. This will let us safely mergehybrid-applicationtomasterand further todogfooding. This flag is defined indogfooding/Package.swiftso the feature will be visible in dogfood projects.DD_SDK_ENABLE_EXPERIMENTAL_APIStoBase.local.xcconfigfor local development. This is automated as part ofmake dependenciesfor CI.Review checklist