Twilio: allow service name flattening #8025

amarziali · 2024-11-27T10:25:29Z

What Does This Do

Allows using DD_SERVICE when the naming schema is v1 or if DD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLED=true

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMS-13987

pr-commenter · 2024-11-27T11:05:10Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/twilio
git_commit_date	1732656091	1732702963
git_commit_sha	`9eaf5a0`	`19c0001`
release_version	1.44.0-SNAPSHOT~9eaf5a01bb	1.44.0-SNAPSHOT~19c00013a0

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732705465	1732705465
ci_job_id	721795371	721795371
ci_pipeline_id	50049584	50049584
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~19c00013a0, baseline=1.44.0-SNAPSHOT~9eaf5a01bb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093692
Total [baseline] (10.447 s) : 0, 10446503
Agent [candidate] (1.1 s) : 0, 1100291
Total [candidate] (10.448 s) : 0, 10448136
section appsec
Agent [baseline] (1.226 s) : 0, 1225644
Total [baseline] (10.732 s) : 0, 10732321
Agent [candidate] (1.224 s) : 0, 1223673
Total [candidate] (10.738 s) : 0, 10737511
section iast
Agent [baseline] (1.217 s) : 0, 1216506
Total [baseline] (10.918 s) : 0, 10918390
Agent [candidate] (1.22 s) : 0, 1220077
Total [candidate] (10.926 s) : 0, 10926350
section profiling
Agent [baseline] (1.322 s) : 0, 1321732
Total [baseline] (10.829 s) : 0, 10829039
Agent [candidate] (1.321 s) : 0, 1321248
Total [candidate] (10.852 s) : 0, 10852051

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.094 s	-
Agent	appsec	1.226 s	131.951 ms (12.1%)
Agent	iast	1.217 s	122.813 ms (11.2%)
Agent	profiling	1.322 s	228.04 ms (20.9%)
Total	tracing	10.447 s	-
Total	appsec	10.732 s	285.818 ms (2.7%)
Total	iast	10.918 s	471.887 ms (4.5%)
Total	profiling	10.829 s	382.536 ms (3.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.1 s	-
Agent	appsec	1.224 s	123.382 ms (11.2%)
Agent	iast	1.22 s	119.786 ms (10.9%)
Agent	profiling	1.321 s	220.957 ms (20.1%)
Total	tracing	10.448 s	-
Total	appsec	10.738 s	289.375 ms (2.8%)
Total	iast	10.926 s	478.214 ms (4.6%)
Total	profiling	10.852 s	403.915 ms (3.9%)

gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~19c00013a0, baseline=1.44.0-SNAPSHOT~9eaf5a01bb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.424 ms) : 0, 695424
BytebuddyAgent [candidate] (699.74 ms) : 0, 699740
GlobalTracer [baseline] (317.198 ms) : 0, 317198
GlobalTracer [candidate] (320.383 ms) : 0, 320383
AppSec [baseline] (54.606 ms) : 0, 54606
AppSec [candidate] (54.964 ms) : 0, 54964
Remote Config [baseline] (673.529 µs) : 0, 674
Remote Config [candidate] (677.812 µs) : 0, 678
Telemetry [baseline] (11.993 ms) : 0, 11993
Telemetry [candidate] (10.692 ms) : 0, 10692
section appsec
BytebuddyAgent [baseline] (711.99 ms) : 0, 711990
BytebuddyAgent [candidate] (710.199 ms) : 0, 710199
GlobalTracer [baseline] (314.559 ms) : 0, 314559
GlobalTracer [candidate] (314.325 ms) : 0, 314325
AppSec [baseline] (166.65 ms) : 0, 166650
AppSec [candidate] (166.788 ms) : 0, 166788
IAST [baseline] (19.164 ms) : 0, 19164
IAST [candidate] (18.906 ms) : 0, 18906
Remote Config [baseline] (648.878 µs) : 0, 649
Remote Config [candidate] (638.483 µs) : 0, 638
Telemetry [baseline] (8.555 ms) : 0, 8555
Telemetry [candidate] (8.568 ms) : 0, 8568
section iast
BytebuddyAgent [baseline] (810.447 ms) : 0, 810447
BytebuddyAgent [candidate] (812.993 ms) : 0, 812993
GlobalTracer [baseline] (306.144 ms) : 0, 306144
GlobalTracer [candidate] (306.158 ms) : 0, 306158
AppSec [baseline] (56.68 ms) : 0, 56680
AppSec [candidate] (57.406 ms) : 0, 57406
IAST [baseline] (21.486 ms) : 0, 21486
IAST [candidate] (21.635 ms) : 0, 21635
Remote Config [baseline] (608.414 µs) : 0, 608
Remote Config [candidate] (625.874 µs) : 0, 626
Telemetry [baseline] (7.441 ms) : 0, 7441
Telemetry [candidate] (7.536 ms) : 0, 7536
section profiling
BytebuddyAgent [baseline] (691.487 ms) : 0, 691487
BytebuddyAgent [candidate] (689.484 ms) : 0, 689484
GlobalTracer [baseline] (435.061 ms) : 0, 435061
GlobalTracer [candidate] (435.895 ms) : 0, 435895
AppSec [baseline] (53.86 ms) : 0, 53860
AppSec [candidate] (54.186 ms) : 0, 54186
Remote Config [baseline] (656.911 µs) : 0, 657
Remote Config [candidate] (663.739 µs) : 0, 664
Telemetry [baseline] (7.725 ms) : 0, 7725
Telemetry [candidate] (7.805 ms) : 0, 7805
ProfilingAgent [baseline] (93.929 ms) : 0, 93929
ProfilingAgent [candidate] (94.174 ms) : 0, 94174
Profiling [baseline] (93.952 ms) : 0, 93952
Profiling [candidate] (94.198 ms) : 0, 94198

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~19c00013a0, baseline=1.44.0-SNAPSHOT~9eaf5a01bb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1098293
Total [baseline] (8.706 s) : 0, 8705873
Agent [candidate] (1.09 s) : 0, 1090227
Total [candidate] (8.657 s) : 0, 8657313
section iast
Agent [baseline] (1.224 s) : 0, 1224126
Total [baseline] (9.245 s) : 0, 9244935
Agent [candidate] (1.225 s) : 0, 1224912
Total [candidate] (9.195 s) : 0, 9195360
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.216 s) : 0, 1216336
Total [baseline] (9.159 s) : 0, 9158970
Agent [candidate] (1.218 s) : 0, 1218083
Total [candidate] (9.183 s) : 0, 9183016
section iast_TELEMETRY_OFF
Agent [baseline] (1.223 s) : 0, 1222531
Total [baseline] (9.184 s) : 0, 9184236
Agent [candidate] (1.223 s) : 0, 1222677
Total [candidate] (9.197 s) : 0, 9196736

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.098 s	-
Agent	iast	1.224 s	125.832 ms (11.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.216 s	118.043 ms (10.7%)
Agent	iast_TELEMETRY_OFF	1.223 s	124.238 ms (11.3%)
Total	tracing	8.706 s	-
Total	iast	9.245 s	539.061 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.159 s	453.097 ms (5.2%)
Total	iast_TELEMETRY_OFF	9.184 s	478.363 ms (5.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.09 s	-
Agent	iast	1.225 s	134.685 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.218 s	127.856 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.223 s	132.449 ms (12.1%)
Total	tracing	8.657 s	-
Total	iast	9.195 s	538.047 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.183 s	525.703 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.197 s	539.424 ms (6.2%)

gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~19c00013a0, baseline=1.44.0-SNAPSHOT~9eaf5a01bb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (698.376 ms) : 0, 698376
BytebuddyAgent [candidate] (693.261 ms) : 0, 693261
GlobalTracer [baseline] (319.233 ms) : 0, 319233
GlobalTracer [candidate] (317.974 ms) : 0, 317974
AppSec [baseline] (54.934 ms) : 0, 54934
AppSec [candidate] (54.732 ms) : 0, 54732
Remote Config [baseline] (683.601 µs) : 0, 684
Remote Config [candidate] (675.876 µs) : 0, 676
Telemetry [baseline] (11.33 ms) : 0, 11330
Telemetry [candidate] (9.863 ms) : 0, 9863
section iast
BytebuddyAgent [baseline] (815.939 ms) : 0, 815939
BytebuddyAgent [candidate] (815.78 ms) : 0, 815780
GlobalTracer [baseline] (307.257 ms) : 0, 307257
GlobalTracer [candidate] (307.709 ms) : 0, 307709
AppSec [baseline] (57.224 ms) : 0, 57224
AppSec [candidate] (57.531 ms) : 0, 57531
IAST [baseline] (21.577 ms) : 0, 21577
IAST [candidate] (21.859 ms) : 0, 21859
Remote Config [baseline] (633.941 µs) : 0, 634
Remote Config [candidate] (622.798 µs) : 0, 623
Telemetry [baseline] (7.537 ms) : 0, 7537
Telemetry [candidate] (7.565 ms) : 0, 7565
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (810.414 ms) : 0, 810414
BytebuddyAgent [candidate] (811.158 ms) : 0, 811158
GlobalTracer [baseline] (305.878 ms) : 0, 305878
GlobalTracer [candidate] (306.84 ms) : 0, 306840
AppSec [baseline] (57.724 ms) : 0, 57724
AppSec [candidate] (57.693 ms) : 0, 57693
IAST [baseline] (20.588 ms) : 0, 20588
IAST [candidate] (20.606 ms) : 0, 20606
Remote Config [baseline] (605.125 µs) : 0, 605
Remote Config [candidate] (609.544 µs) : 0, 610
Telemetry [baseline] (7.449 ms) : 0, 7449
Telemetry [candidate] (7.476 ms) : 0, 7476
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (814.405 ms) : 0, 814405
BytebuddyAgent [candidate] (813.998 ms) : 0, 813998
GlobalTracer [baseline] (308.601 ms) : 0, 308601
GlobalTracer [candidate] (308.945 ms) : 0, 308945
AppSec [baseline] (57.565 ms) : 0, 57565
AppSec [candidate] (57.725 ms) : 0, 57725
IAST [baseline] (20.138 ms) : 0, 20138
IAST [candidate] (20.202 ms) : 0, 20202
Remote Config [baseline] (615.915 µs) : 0, 616
Remote Config [candidate] (602.209 µs) : 0, 602
Telemetry [baseline] (7.396 ms) : 0, 7396
Telemetry [candidate] (7.374 ms) : 0, 7374

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-27T10:34:32	2024-11-27T10:41:31
git_branch	master	andrea.marziali/twilio
git_commit_date	1732656091	1732702963
git_commit_sha	`9eaf5a0`	`19c0001`
release_version	1.44.0-SNAPSHOT~9eaf5a01bb	1.44.0-SNAPSHOT~19c00013a0
start_time	2024-11-27T10:34:18	2024-11-27T10:41:18

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732704446	1732704446
ci_job_id	721795372	721795372
ci_pipeline_id	50049584	50049584
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~19c00013a0, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.006 µs) : 357, 397
.   : milestone, 377,
iast (494.406 µs) : 473, 516
.   : milestone, 494,
iast_FULL (652.997 µs) : 631, 675
.   : milestone, 653,
iast_GLOBAL (520.331 µs) : 499, 542
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (495.124 µs) : 474, 517
.   : milestone, 495,
iast_INACTIVE (458.974 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (487.064 µs) : 466, 509
.   : milestone, 487,
tracing (454.437 µs) : 434, 475
.   : milestone, 454,
section candidate
no_agent (380.046 µs) : 359, 401
.   : milestone, 380,
iast (492.9 µs) : 472, 514
.   : milestone, 493,
iast_FULL (656.251 µs) : 635, 678
.   : milestone, 656,
iast_GLOBAL (521.49 µs) : 499, 544
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (500.919 µs) : 479, 523
.   : milestone, 501,
iast_INACTIVE (455.086 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (489.112 µs) : 468, 511
.   : milestone, 489,
tracing (456.106 µs) : 435, 477
.   : milestone, 456,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.006 µs [357.267 µs, 396.744 µs]	-
iast	494.406 µs [473.011 µs, 515.801 µs]	117.401 µs (31.1%)
iast_FULL	652.997 µs [631.439 µs, 674.556 µs]	275.992 µs (73.2%)
iast_GLOBAL	520.331 µs [499.052 µs, 541.61 µs]	143.326 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED	495.124 µs [473.603 µs, 516.644 µs]	118.118 µs (31.3%)
iast_INACTIVE	458.974 µs [437.903 µs, 480.045 µs]	81.969 µs (21.7%)
iast_TELEMETRY_OFF	487.064 µs [465.55 µs, 508.579 µs]	110.059 µs (29.2%)
tracing	454.437 µs [433.796 µs, 475.079 µs]	77.432 µs (20.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.046 µs [359.422 µs, 400.67 µs]	-
iast	492.9 µs [471.575 µs, 514.225 µs]	112.854 µs (29.7%)
iast_FULL	656.251 µs [634.557 µs, 677.945 µs]	276.205 µs (72.7%)
iast_GLOBAL	521.49 µs [499.231 µs, 543.749 µs]	141.444 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED	500.919 µs [479.248 µs, 522.589 µs]	120.873 µs (31.8%)
iast_INACTIVE	455.086 µs [434.214 µs, 475.958 µs]	75.04 µs (19.7%)
iast_TELEMETRY_OFF	489.112 µs [467.541 µs, 510.684 µs]	109.066 µs (28.7%)
tracing	456.106 µs [434.871 µs, 477.341 µs]	76.06 µs (20.0%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~19c00013a0, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1366
.   : milestone, 1346,
appsec (1.766 ms) : 1741, 1790
.   : milestone, 1766,
appsec_no_iast (1.764 ms) : 1740, 1788
.   : milestone, 1764,
iast (1.494 ms) : 1471, 1517
.   : milestone, 1494,
profiling (1.509 ms) : 1487, 1532
.   : milestone, 1509,
tracing (1.486 ms) : 1461, 1512
.   : milestone, 1486,
section candidate
no_agent (1.353 ms) : 1332, 1373
.   : milestone, 1353,
appsec (1.765 ms) : 1740, 1790
.   : milestone, 1765,
appsec_no_iast (1.759 ms) : 1734, 1784
.   : milestone, 1759,
iast (1.516 ms) : 1494, 1538
.   : milestone, 1516,
profiling (1.533 ms) : 1507, 1558
.   : milestone, 1533,
tracing (1.491 ms) : 1466, 1516
.   : milestone, 1491,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.346 ms [1.327 ms, 1.366 ms]	-
appsec	1.766 ms [1.741 ms, 1.79 ms]	419.099 µs (31.1%)
appsec_no_iast	1.764 ms [1.74 ms, 1.788 ms]	417.673 µs (31.0%)
iast	1.494 ms [1.471 ms, 1.517 ms]	147.286 µs (10.9%)
profiling	1.509 ms [1.487 ms, 1.532 ms]	162.834 µs (12.1%)
tracing	1.486 ms [1.461 ms, 1.512 ms]	139.961 µs (10.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.353 ms [1.332 ms, 1.373 ms]	-
appsec	1.765 ms [1.74 ms, 1.79 ms]	412.47 µs (30.5%)
appsec_no_iast	1.759 ms [1.734 ms, 1.784 ms]	406.013 µs (30.0%)
iast	1.516 ms [1.494 ms, 1.538 ms]	163.05 µs (12.1%)
profiling	1.533 ms [1.507 ms, 1.558 ms]	180.008 µs (13.3%)
tracing	1.491 ms [1.466 ms, 1.516 ms]	138.149 µs (10.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/twilio
git_commit_date	1732656091	1732702963
git_commit_sha	`9eaf5a0`	`19c0001`
release_version	1.44.0-SNAPSHOT~9eaf5a01bb	1.44.0-SNAPSHOT~19c00013a0

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732704966	1732704966
ci_job_id	721795373	721795373
ci_pipeline_id	50049584	50049584
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~19c00013a0, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.515 s) : 15515000, 15515000
.   : milestone, 15515000,
appsec (15.197 s) : 15197000, 15197000
.   : milestone, 15197000,
iast (18.51 s) : 18510000, 18510000
.   : milestone, 18510000,
iast_GLOBAL (18.226 s) : 18226000, 18226000
.   : milestone, 18226000,
profiling (15.067 s) : 15067000, 15067000
.   : milestone, 15067000,
tracing (14.965 s) : 14965000, 14965000
.   : milestone, 14965000,
section candidate
no_agent (15.193 s) : 15193000, 15193000
.   : milestone, 15193000,
appsec (14.937 s) : 14937000, 14937000
.   : milestone, 14937000,
iast (18.864 s) : 18864000, 18864000
.   : milestone, 18864000,
iast_GLOBAL (18.157 s) : 18157000, 18157000
.   : milestone, 18157000,
profiling (14.677 s) : 14677000, 14677000
.   : milestone, 14677000,
tracing (14.784 s) : 14784000, 14784000
.   : milestone, 14784000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.515 s [15.515 s, 15.515 s]	-
appsec	15.197 s [15.197 s, 15.197 s]	-318.0 ms (-2.0%)
iast	18.51 s [18.51 s, 18.51 s]	2.995 s (19.3%)
iast_GLOBAL	18.226 s [18.226 s, 18.226 s]	2.711 s (17.5%)
profiling	15.067 s [15.067 s, 15.067 s]	-448.0 ms (-2.9%)
tracing	14.965 s [14.965 s, 14.965 s]	-550.0 ms (-3.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.193 s [15.193 s, 15.193 s]	-
appsec	14.937 s [14.937 s, 14.937 s]	-256.0 ms (-1.7%)
iast	18.864 s [18.864 s, 18.864 s]	3.671 s (24.2%)
iast_GLOBAL	18.157 s [18.157 s, 18.157 s]	2.964 s (19.5%)
profiling	14.677 s [14.677 s, 14.677 s]	-516.0 ms (-3.4%)
tracing	14.784 s [14.784 s, 14.784 s]	-409.0 ms (-2.7%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~19c00013a0, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.338 ms) : 2297, 2379
.   : milestone, 2338,
iast (2.075 ms) : 2022, 2127
.   : milestone, 2075,
iast_GLOBAL (2.122 ms) : 2069, 2175
.   : milestone, 2122,
profiling (1.943 ms) : 1901, 1985
.   : milestone, 1943,
tracing (1.921 ms) : 1881, 1961
.   : milestone, 1921,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.344 ms) : 2302, 2385
.   : milestone, 2344,
iast (2.077 ms) : 2024, 2129
.   : milestone, 2077,
iast_GLOBAL (2.125 ms) : 2072, 2178
.   : milestone, 2125,
profiling (1.956 ms) : 1913, 1999
.   : milestone, 1956,
tracing (1.921 ms) : 1881, 1961
.   : milestone, 1921,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	2.338 ms [2.297 ms, 2.379 ms]	865.861 µs (58.8%)
iast	2.075 ms [2.022 ms, 2.127 ms]	602.972 µs (41.0%)
iast_GLOBAL	2.122 ms [2.069 ms, 2.175 ms]	649.955 µs (44.2%)
profiling	1.943 ms [1.901 ms, 1.985 ms]	471.25 µs (32.0%)
tracing	1.921 ms [1.881 ms, 1.961 ms]	448.983 µs (30.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.344 ms [2.302 ms, 2.385 ms]	873.11 µs (59.4%)
iast	2.077 ms [2.024 ms, 2.129 ms]	606.245 µs (41.2%)
iast_GLOBAL	2.125 ms [2.072 ms, 2.178 ms]	654.386 µs (44.5%)
profiling	1.956 ms [1.913 ms, 1.999 ms]	485.587 µs (33.0%)
tracing	1.921 ms [1.881 ms, 1.961 ms]	450.619 µs (30.6%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#8089](DataDog/dd-trace-java#8089) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#8044](DataDog/dd-trace-java#8044) - [@smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#8038](DataDog/dd-trace-java#8038) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#8026](DataDog/dd-trace-java#8026) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#8013](DataDog/dd-trace-java#8013) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#8010](DataDog/dd-trace-java#8010) - [@Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#8004](DataDog/dd-trace-java#8004) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#8078](DataDog/dd-trace-java#8078) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#8055](DataDog/dd-trace-java#8055) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#8033](DataDog/dd-trace-java#8033) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#8030](DataDog/dd-trace-java#8030) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#8045](DataDog/dd-trace-java#8045) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#8071](DataDog/dd-trace-java#8071) - [@piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#8051](DataDog/dd-trace-java#8051) - [@kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#8039](DataDog/dd-trace-java#8039) - [@jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#8021](DataDog/dd-trace-java#8021) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#8016](DataDog/dd-trace-java#8016) - [@evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#7942](DataDog/dd-trace-java#7942) - [@evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#8065](DataDog/dd-trace-java#8065) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#8036](DataDog/dd-trace-java#8036) - [@mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#8058](DataDog/dd-trace-java#8058) - [@mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#8064](DataDog/dd-trace-java#8064) - [@amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#8061](DataDog/dd-trace-java#8061) - [@amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#8040](DataDog/dd-trace-java#8040) - [@cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#8028](DataDog/dd-trace-java#8028) - [@mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#7973](DataDog/dd-trace-java#7973) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#7946](DataDog/dd-trace-java#7946) - [@smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#8043](DataDog/dd-trace-java#8043) - [@amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#7940](DataDog/dd-trace-java#7940) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#8062](DataDog/dd-trace-java#8062) - [@amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#8019](DataDog/dd-trace-java#8019) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#8005](DataDog/dd-trace-java#8005) - [@amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#8025](DataDog/dd-trace-java#8025) - [@amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#7981](DataDog/dd-trace-java#7981) - [@amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c

Twilio: allow service name flattening

19c0001

amarziali added type: bug inst: others All other instrumentations labels Nov 27, 2024

amarziali requested a review from a team as a code owner November 27, 2024 10:25

PerfectSlayer approved these changes Nov 27, 2024

View reviewed changes

amarziali enabled auto-merge (squash) November 27, 2024 10:30

amarziali merged commit 107788f into master Nov 27, 2024
109 checks passed

amarziali deleted the andrea.marziali/twilio branch November 27, 2024 11:51

github-actions bot added this to the 1.44.0 milestone Nov 27, 2024

PerfectSlayer pushed a commit that referenced this pull request Nov 28, 2024

Twilio: allow service name flattening (#8025)

a58de5c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Twilio: allow service name flattening #8025

Twilio: allow service name flattening #8025

amarziali commented Nov 27, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Nov 27, 2024

Twilio: allow service name flattening #8025

Twilio: allow service name flattening #8025

Conversation

amarziali commented Nov 27, 2024 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Nov 27, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

amarziali commented Nov 27, 2024 •

edited by jira bot

Loading