TempLocationManager Fixes and Improvements #8191

jbachorik · 2025-01-13T16:36:56Z

What Does This Do

It fixes the the problem caused by the usage of CompletableFuture in the manager.
It avoids forking jps unless there is something to clean up.
It avoids removing JFR repository during self-cleanup in order to avoid clashing with the JFR shutdown.

Motivation

Prevent unexpected behaviour, reduce the overhead.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: PROF-11072

pr-commenter · 2025-01-13T17:14:39Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/tempmanager_fixes
git_commit_date	1736782292	1736787690
git_commit_sha	`9b8eee7`	`9a12fe2`
release_version	1.46.0-SNAPSHOT~9b8eee7dae	1.46.0-SNAPSHOT~9a12fe26e0

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736789990	1736789990
ci_job_id	764229453	764229453
ci_pipeline_id	52846331	52846331
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 2 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:profiling:GlobalTracer	better [-20.383ms; -16.101ms] or [-5.527%; -4.366%]	350.572ms	368.814ms
scenario:startup:petclinic:profiling:Remote Config	better [-63.631µs; -18.476µs] or [-8.998%; -2.613%]	666.101µs	707.155µs

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~9a12fe26e0, baseline=1.46.0-SNAPSHOT~9b8eee7dae

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057451
Total [baseline] (10.468 s) : 0, 10468137
Agent [candidate] (1.057 s) : 0, 1056684
Total [candidate] (10.493 s) : 0, 10493256
section appsec
Agent [baseline] (1.195 s) : 0, 1195499
Total [baseline] (10.707 s) : 0, 10706635
Agent [candidate] (1.187 s) : 0, 1187347
Total [candidate] (10.748 s) : 0, 10748056
section iast
Agent [baseline] (1.185 s) : 0, 1184828
Total [baseline] (10.968 s) : 0, 10967502
Agent [candidate] (1.185 s) : 0, 1185102
Total [candidate] (10.996 s) : 0, 10995961
section profiling
Agent [baseline] (1.273 s) : 0, 1273344
Total [baseline] (10.948 s) : 0, 10948358
Agent [candidate] (1.258 s) : 0, 1257630
Total [candidate] (10.859 s) : 0, 10859351

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	appsec	1.195 s	138.047 ms (13.1%)
Agent	iast	1.185 s	127.377 ms (12.0%)
Agent	profiling	1.273 s	215.893 ms (20.4%)
Total	tracing	10.468 s	-
Total	appsec	10.707 s	238.498 ms (2.3%)
Total	iast	10.968 s	499.365 ms (4.8%)
Total	profiling	10.948 s	480.22 ms (4.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	appsec	1.187 s	130.664 ms (12.4%)
Agent	iast	1.185 s	128.419 ms (12.2%)
Agent	profiling	1.258 s	200.946 ms (19.0%)
Total	tracing	10.493 s	-
Total	appsec	10.748 s	254.8 ms (2.4%)
Total	iast	10.996 s	502.705 ms (4.8%)
Total	profiling	10.859 s	366.095 ms (3.5%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~9a12fe26e0, baseline=1.46.0-SNAPSHOT~9b8eee7dae

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.97 ms) : 0, 714970
BytebuddyAgent [candidate] (714.007 ms) : 0, 714007
GlobalTracer [baseline] (256.694 ms) : 0, 256694
GlobalTracer [candidate] (256.23 ms) : 0, 256230
AppSec [baseline] (56.381 ms) : 0, 56381
AppSec [candidate] (55.29 ms) : 0, 55290
Remote Config [baseline] (740.312 µs) : 0, 740
Remote Config [candidate] (730.295 µs) : 0, 730
Telemetry [baseline] (13.634 ms) : 0, 13634
Telemetry [candidate] (15.366 ms) : 0, 15366
section appsec
BytebuddyAgent [baseline] (735.697 ms) : 0, 735697
BytebuddyAgent [candidate] (730.486 ms) : 0, 730486
GlobalTracer [baseline] (254.726 ms) : 0, 254726
GlobalTracer [candidate] (252.583 ms) : 0, 252583
AppSec [baseline] (171.373 ms) : 0, 171373
AppSec [candidate] (170.633 ms) : 0, 170633
Remote Config [baseline] (672.01 µs) : 0, 672
Remote Config [candidate] (674.296 µs) : 0, 674
Telemetry [baseline] (8.25 ms) : 0, 8250
Telemetry [candidate] (8.262 ms) : 0, 8262
IAST [baseline] (19.537 ms) : 0, 19537
IAST [candidate] (19.472 ms) : 0, 19472
section iast
BytebuddyAgent [baseline] (832.79 ms) : 0, 832790
BytebuddyAgent [candidate] (833.181 ms) : 0, 833181
GlobalTracer [baseline] (247.414 ms) : 0, 247414
GlobalTracer [candidate] (247.498 ms) : 0, 247498
AppSec [baseline] (58.279 ms) : 0, 58279
AppSec [candidate] (58.422 ms) : 0, 58422
Remote Config [baseline] (679.937 µs) : 0, 680
Remote Config [candidate] (677.27 µs) : 0, 677
Telemetry [baseline] (8.846 ms) : 0, 8846
Telemetry [candidate] (8.769 ms) : 0, 8769
IAST [baseline] (21.75 ms) : 0, 21750
IAST [candidate] (21.519 ms) : 0, 21519
section profiling
ProfilingAgent [baseline] (95.459 ms) : 0, 95459
ProfilingAgent [candidate] (95.725 ms) : 0, 95725
BytebuddyAgent [baseline] (703.583 ms) : 0, 703583
BytebuddyAgent [candidate] (705.073 ms) : 0, 705073
GlobalTracer [baseline] (368.814 ms) : 0, 368814
GlobalTracer [candidate] (350.572 ms) : 0, 350572
AppSec [baseline] (53.985 ms) : 0, 53985
AppSec [candidate] (54.668 ms) : 0, 54668
Remote Config [baseline] (707.155 µs) : 0, 707
Remote Config [candidate] (666.101 µs) : 0, 666
Telemetry [baseline] (8.867 ms) : 0, 8867
Telemetry [candidate] (8.861 ms) : 0, 8861
Profiling [baseline] (95.483 ms) : 0, 95483
Profiling [candidate] (95.749 ms) : 0, 95749

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~9a12fe26e0, baseline=1.46.0-SNAPSHOT~9b8eee7dae

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056575
Total [baseline] (8.638 s) : 0, 8638136
Agent [candidate] (1.065 s) : 0, 1064973
Total [candidate] (8.633 s) : 0, 8633308
section iast
Agent [baseline] (1.181 s) : 0, 1181242
Total [baseline] (9.227 s) : 0, 9226558
Agent [candidate] (1.184 s) : 0, 1183999
Total [candidate] (9.252 s) : 0, 9252099
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1198217
Total [baseline] (9.272 s) : 0, 9272363
Agent [candidate] (1.182 s) : 0, 1181701
Total [candidate] (9.207 s) : 0, 9207415
section iast_TELEMETRY_OFF
Agent [baseline] (1.193 s) : 0, 1193343
Total [baseline] (9.241 s) : 0, 9240532
Agent [candidate] (1.178 s) : 0, 1178308
Total [candidate] (9.204 s) : 0, 9203916

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	iast	1.181 s	124.668 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.198 s	141.642 ms (13.4%)
Agent	iast_TELEMETRY_OFF	1.193 s	136.769 ms (12.9%)
Total	tracing	8.638 s	-
Total	iast	9.227 s	588.422 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.272 s	634.227 ms (7.3%)
Total	iast_TELEMETRY_OFF	9.241 s	602.396 ms (7.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.065 s	-
Agent	iast	1.184 s	119.025 ms (11.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.182 s	116.727 ms (11.0%)
Agent	iast_TELEMETRY_OFF	1.178 s	113.334 ms (10.6%)
Total	tracing	8.633 s	-
Total	iast	9.252 s	618.791 ms (7.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.207 s	574.106 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.204 s	570.608 ms (6.6%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~9a12fe26e0, baseline=1.46.0-SNAPSHOT~9b8eee7dae

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.166 ms) : 0, 714166
BytebuddyAgent [candidate] (720.503 ms) : 0, 720503
GlobalTracer [baseline] (256.013 ms) : 0, 256013
GlobalTracer [candidate] (258.305 ms) : 0, 258305
AppSec [baseline] (55.453 ms) : 0, 55453
AppSec [candidate] (55.726 ms) : 0, 55726
Remote Config [baseline] (728.874 µs) : 0, 729
Remote Config [candidate] (742.884 µs) : 0, 743
Telemetry [baseline] (15.177 ms) : 0, 15177
Telemetry [candidate] (14.592 ms) : 0, 14592
section iast
BytebuddyAgent [baseline] (831.079 ms) : 0, 831079
BytebuddyAgent [candidate] (832.394 ms) : 0, 832394
GlobalTracer [baseline] (246.696 ms) : 0, 246696
GlobalTracer [candidate] (247.465 ms) : 0, 247465
AppSec [baseline] (57.781 ms) : 0, 57781
AppSec [candidate] (58.088 ms) : 0, 58088
IAST [baseline] (21.317 ms) : 0, 21317
IAST [candidate] (21.472 ms) : 0, 21472
Remote Config [baseline] (667.518 µs) : 0, 668
Remote Config [candidate] (672.583 µs) : 0, 673
Telemetry [baseline] (8.699 ms) : 0, 8699
Telemetry [candidate] (8.828 ms) : 0, 8828
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (842.593 ms) : 0, 842593
BytebuddyAgent [candidate] (830.577 ms) : 0, 830577
GlobalTracer [baseline] (250.031 ms) : 0, 250031
GlobalTracer [candidate] (246.753 ms) : 0, 246753
AppSec [baseline] (58.904 ms) : 0, 58904
AppSec [candidate] (58.455 ms) : 0, 58455
IAST [baseline] (21.928 ms) : 0, 21928
IAST [candidate] (21.449 ms) : 0, 21449
Remote Config [baseline] (682.349 µs) : 0, 682
Remote Config [candidate] (677.74 µs) : 0, 678
Telemetry [baseline] (8.991 ms) : 0, 8991
Telemetry [candidate] (8.832 ms) : 0, 8832
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (840.155 ms) : 0, 840155
BytebuddyAgent [candidate] (828.435 ms) : 0, 828435
GlobalTracer [baseline] (249.169 ms) : 0, 249169
GlobalTracer [candidate] (246.92 ms) : 0, 246920
AppSec [baseline] (58.286 ms) : 0, 58286
AppSec [candidate] (57.847 ms) : 0, 57847
IAST [baseline] (21.102 ms) : 0, 21102
IAST [candidate] (20.788 ms) : 0, 20788
Remote Config [baseline] (663.449 µs) : 0, 663
Remote Config [candidate] (662.334 µs) : 0, 662
Telemetry [baseline] (8.773 ms) : 0, 8773
Telemetry [candidate] (8.648 ms) : 0, 8648

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-13T17:09:56	2025-01-13T17:16:56
git_branch	master	jb/tempmanager_fixes
git_commit_date	1736782292	1736787690
git_commit_sha	`9b8eee7`	`9a12fe2`
release_version	1.46.0-SNAPSHOT~9b8eee7dae	1.46.0-SNAPSHOT~9a12fe26e0
start_time	2025-01-13T17:09:42	2025-01-13T17:16:42

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736788973	1736788973
ci_job_id	764229454	764229454
ci_pipeline_id	52846331	52846331
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	worse [+33.197µs; +97.064µs] or [+2.206%; +6.451%]	unstable [-672.949op/s; +445.029op/s] or [-21.871%; +14.463%]	1.570ms	2962.963op/s	1.505ms	3076.923op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~9a12fe26e0, baseline=1.46.0-SNAPSHOT~9b8eee7dae
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.583 µs) : 357, 396
.   : milestone, 377,
iast (504.604 µs) : 483, 526
.   : milestone, 505,
iast_FULL (659.215 µs) : 637, 681
.   : milestone, 659,
iast_GLOBAL (530.565 µs) : 509, 552
.   : milestone, 531,
iast_HARDCODED_SECRET_DISABLED (502.957 µs) : 481, 525
.   : milestone, 503,
iast_INACTIVE (463.798 µs) : 443, 485
.   : milestone, 464,
iast_TELEMETRY_OFF (485.494 µs) : 464, 507
.   : milestone, 485,
tracing (454.163 µs) : 433, 475
.   : milestone, 454,
section candidate
no_agent (382.9 µs) : 363, 403
.   : milestone, 383,
iast (495.531 µs) : 474, 517
.   : milestone, 496,
iast_FULL (663.294 µs) : 642, 685
.   : milestone, 663,
iast_GLOBAL (536.303 µs) : 513, 560
.   : milestone, 536,
iast_HARDCODED_SECRET_DISABLED (501.817 µs) : 481, 523
.   : milestone, 502,
iast_INACTIVE (459.868 µs) : 439, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (490.54 µs) : 469, 512
.   : milestone, 491,
tracing (458.52 µs) : 437, 480
.   : milestone, 459,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.583 µs [356.685 µs, 396.481 µs]	-
iast	504.604 µs [482.774 µs, 526.433 µs]	128.021 µs (34.0%)
iast_FULL	659.215 µs [637.364 µs, 681.066 µs]	282.632 µs (75.1%)
iast_GLOBAL	530.565 µs [509.015 µs, 552.115 µs]	153.981 µs (40.9%)
iast_HARDCODED_SECRET_DISABLED	502.957 µs [481.266 µs, 524.649 µs]	126.374 µs (33.6%)
iast_INACTIVE	463.798 µs [442.578 µs, 485.018 µs]	87.215 µs (23.2%)
iast_TELEMETRY_OFF	485.494 µs [464.087 µs, 506.9 µs]	108.91 µs (28.9%)
tracing	454.163 µs [433.209 µs, 475.117 µs]	77.579 µs (20.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.9 µs [362.741 µs, 403.06 µs]	-
iast	495.531 µs [474.016 µs, 517.045 µs]	112.63 µs (29.4%)
iast_FULL	663.294 µs [641.506 µs, 685.083 µs]	280.394 µs (73.2%)
iast_GLOBAL	536.303 µs [512.981 µs, 559.626 µs]	153.403 µs (40.1%)
iast_HARDCODED_SECRET_DISABLED	501.817 µs [480.509 µs, 523.125 µs]	118.917 µs (31.1%)
iast_INACTIVE	459.868 µs [438.863 µs, 480.873 µs]	76.968 µs (20.1%)
iast_TELEMETRY_OFF	490.54 µs [468.948 µs, 512.132 µs]	107.64 µs (28.1%)
tracing	458.52 µs [437.275 µs, 479.766 µs]	75.62 µs (19.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~9a12fe26e0, baseline=1.46.0-SNAPSHOT~9b8eee7dae
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.376 ms) : 1357, 1396
.   : milestone, 1376,
appsec (1.746 ms) : 1723, 1770
.   : milestone, 1746,
appsec_no_iast (1.772 ms) : 1748, 1797
.   : milestone, 1772,
iast (1.498 ms) : 1475, 1520
.   : milestone, 1498,
profiling (1.505 ms) : 1481, 1528
.   : milestone, 1505,
tracing (1.495 ms) : 1470, 1520
.   : milestone, 1495,
section candidate
no_agent (1.365 ms) : 1346, 1384
.   : milestone, 1365,
appsec (1.772 ms) : 1748, 1796
.   : milestone, 1772,
appsec_no_iast (1.751 ms) : 1727, 1775
.   : milestone, 1751,
iast (1.511 ms) : 1487, 1534
.   : milestone, 1511,
profiling (1.57 ms) : 1535, 1605
.   : milestone, 1570,
tracing (1.502 ms) : 1478, 1526
.   : milestone, 1502,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.376 ms [1.357 ms, 1.396 ms]	-
appsec	1.746 ms [1.723 ms, 1.77 ms]	370.163 µs (26.9%)
appsec_no_iast	1.772 ms [1.748 ms, 1.797 ms]	395.89 µs (28.8%)
iast	1.498 ms [1.475 ms, 1.52 ms]	121.639 µs (8.8%)
profiling	1.505 ms [1.481 ms, 1.528 ms]	128.489 µs (9.3%)
tracing	1.495 ms [1.47 ms, 1.52 ms]	118.496 µs (8.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.365 ms [1.346 ms, 1.384 ms]	-
appsec	1.772 ms [1.748 ms, 1.796 ms]	407.119 µs (29.8%)
appsec_no_iast	1.751 ms [1.727 ms, 1.775 ms]	386.442 µs (28.3%)
iast	1.511 ms [1.487 ms, 1.534 ms]	145.656 µs (10.7%)
profiling	1.57 ms [1.535 ms, 1.605 ms]	204.942 µs (15.0%)
tracing	1.502 ms [1.478 ms, 1.526 ms]	136.92 µs (10.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jb/tempmanager_fixes
git_commit_date	1736782292	1736787690
git_commit_sha	`9b8eee7`	`9a12fe2`
release_version	1.46.0-SNAPSHOT~9b8eee7dae	1.46.0-SNAPSHOT~9a12fe26e0

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1736789557	1736789557
ci_job_id	764229455	764229455
ci_pipeline_id	52846331	52846331
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~9a12fe26e0, baseline=1.46.0-SNAPSHOT~9b8eee7dae
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.431 s) : 15431000, 15431000
.   : milestone, 15431000,
appsec (15.001 s) : 15001000, 15001000
.   : milestone, 15001000,
iast (19.039 s) : 19039000, 19039000
.   : milestone, 19039000,
iast_GLOBAL (18.146 s) : 18146000, 18146000
.   : milestone, 18146000,
profiling (15.175 s) : 15175000, 15175000
.   : milestone, 15175000,
tracing (14.769 s) : 14769000, 14769000
.   : milestone, 14769000,
section candidate
no_agent (15.447 s) : 15447000, 15447000
.   : milestone, 15447000,
appsec (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
iast (18.667 s) : 18667000, 18667000
.   : milestone, 18667000,
iast_GLOBAL (17.826 s) : 17826000, 17826000
.   : milestone, 17826000,
profiling (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
tracing (14.832 s) : 14832000, 14832000
.   : milestone, 14832000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.431 s [15.431 s, 15.431 s]	-
appsec	15.001 s [15.001 s, 15.001 s]	-430.0 ms (-2.8%)
iast	19.039 s [19.039 s, 19.039 s]	3.608 s (23.4%)
iast_GLOBAL	18.146 s [18.146 s, 18.146 s]	2.715 s (17.6%)
profiling	15.175 s [15.175 s, 15.175 s]	-256.0 ms (-1.7%)
tracing	14.769 s [14.769 s, 14.769 s]	-662.0 ms (-4.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.447 s [15.447 s, 15.447 s]	-
appsec	15.031 s [15.031 s, 15.031 s]	-416.0 ms (-2.7%)
iast	18.667 s [18.667 s, 18.667 s]	3.22 s (20.8%)
iast_GLOBAL	17.826 s [17.826 s, 17.826 s]	2.379 s (15.4%)
profiling	15.063 s [15.063 s, 15.063 s]	-384.0 ms (-2.5%)
tracing	14.832 s [14.832 s, 14.832 s]	-615.0 ms (-4.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~9a12fe26e0, baseline=1.46.0-SNAPSHOT~9b8eee7dae
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.368 ms) : 2325, 2412
.   : milestone, 2368,
iast (2.108 ms) : 2054, 2163
.   : milestone, 2108,
iast_GLOBAL (2.157 ms) : 2103, 2212
.   : milestone, 2157,
profiling (1.987 ms) : 1942, 2032
.   : milestone, 1987,
tracing (1.955 ms) : 1914, 1997
.   : milestone, 1955,
section candidate
no_agent (1.478 ms) : 1466, 1490
.   : milestone, 1478,
appsec (2.369 ms) : 2326, 2412
.   : milestone, 2369,
iast (2.103 ms) : 2048, 2157
.   : milestone, 2103,
iast_GLOBAL (2.156 ms) : 2102, 2211
.   : milestone, 2156,
profiling (1.972 ms) : 1928, 2015
.   : milestone, 1972,
tracing (1.946 ms) : 1904, 1988
.   : milestone, 1946,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	2.368 ms [2.325 ms, 2.412 ms]	894.895 µs (60.7%)
iast	2.108 ms [2.054 ms, 2.163 ms]	634.748 µs (43.1%)
iast_GLOBAL	2.157 ms [2.103 ms, 2.212 ms]	683.778 µs (46.4%)
profiling	1.987 ms [1.942 ms, 2.032 ms]	513.346 µs (34.8%)
tracing	1.955 ms [1.914 ms, 1.997 ms]	481.754 µs (32.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.49 ms]	-
appsec	2.369 ms [2.326 ms, 2.412 ms]	890.779 µs (60.3%)
iast	2.103 ms [2.048 ms, 2.157 ms]	624.909 µs (42.3%)
iast_GLOBAL	2.156 ms [2.102 ms, 2.211 ms]	678.059 µs (45.9%)
profiling	1.972 ms [1.928 ms, 2.015 ms]	493.859 µs (33.4%)
tracing	1.946 ms [1.904 ms, 1.988 ms]	467.99 µs (31.7%)

* Remove CompletableFuture from TempLocationManager (cherry picked from commit d0eed45) * Do not run the cleanup if there is nothing to clean up (cherry picked from commit 58d5da8) * Exclude JFR repository from temp files self-cleanup (cherry picked from commit a770911)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

jbachorik added 3 commits January 13, 2025 15:05

Remove CompletableFuture from TempLocationManager

d0eed45

Do not run the cleanup if there is nothing to clean up

58d5da8

Exclude JFR repository from temp files self-cleanup

a770911

jbachorik added type: bug comp: profiling Profiling labels Jan 13, 2025

jbachorik marked this pull request as ready for review January 13, 2025 17:00

jbachorik requested a review from a team as a code owner January 13, 2025 17:00

smola added the run-tests: semeru11 Run tests using Sumuru 11 JDK label Jan 13, 2025

Merge branch 'master' into jb/tempmanager_fixes

9a12fe2

jbachorik added run-tests: zulu11 Run tests using Zulu 11 JDK and removed run-tests: zulu11 Run tests using Zulu 11 JDK labels Jan 13, 2025

MattAlp approved these changes Jan 14, 2025

View reviewed changes

jbachorik merged commit 28c0443 into master Jan 14, 2025
181 checks passed

jbachorik deleted the jb/tempmanager_fixes branch January 14, 2025 14:04

github-actions bot added this to the 1.46.0 milestone Jan 14, 2025

jbachorik mentioned this pull request Jan 14, 2025

🍒 #8191 - TempLocationManager Fixes and Improvements #8199

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TempLocationManager Fixes and Improvements #8191

TempLocationManager Fixes and Improvements #8191

jbachorik commented Jan 13, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Jan 13, 2025 •

edited

Loading

TempLocationManager Fixes and Improvements #8191

TempLocationManager Fixes and Improvements #8191

Conversation

jbachorik commented Jan 13, 2025 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Jan 13, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

jbachorik commented Jan 13, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Jan 13, 2025 •

edited

Loading