Simplify code origins. Separate out snapshot generation. #8263

evanchooly · 2025-01-21T18:03:10Z

What Does This Do

This updates the code origin code to only create the instrumentation to decorate to decorate spans with code origin information. If the debugger is enabled, a separate snapshot probe is added to the configuration.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3354

pr-commenter · 2025-01-21T18:23:22Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1737642769	1737643145
end_time	2025-01-23T14:34:05	2025-01-23T14:40:22
git_branch	master	evanchooly/DEBUG-3354
git_commit_sha	`ac29d6c`	`89a5993`
start_time	2025-01-23T14:32:50	2025-01-23T14:39:06

See matching parameters

	Baseline	Candidate
ci_job_id	777762909	777762909
ci_pipeline_id	53800642	53800642
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1737642155	1737642155

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-19.314µs; +46.128µs] or [-7.305%; +17.447%]	unstable [-29.401µs; +61.647µs] or [-9.710%; +20.360%]	unstable [-37.817µs; +71.430µs] or [-11.949%; +22.569%]	unstable [-188.775µs; +374.931µs] or [-31.967%; +63.490%]	same
scenario:basic	unsure [-12.261µs; -0.865µs] or [-4.399%; -0.310%]	same	same	unstable [-123.822µs; +17.613µs] or [-21.818%; +3.103%]	unstable [-103.414op/s; +231.619op/s] or [-4.137%; +9.265%]
scenario:loop	same	same	same	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (302.779 µs) : 278, 327
.   : milestone, 303,
basic (309.841 µs) : 302, 318
.   : milestone, 310,
loop (10.389 ms) : 10288, 10491
.   : milestone, 10389,
section candidate
noprobe (318.902 µs) : 263, 375
.   : milestone, 319,
basic (303.822 µs) : 291, 316
.   : milestone, 304,
loop (10.436 ms) : 10325, 10546
.   : milestone, 10436,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	302.779 µs [278.432 µs, 327.126 µs]
basic	309.841 µs [301.914 µs, 317.768 µs]
loop	10.389 ms [10.288 ms, 10.491 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	318.902 µs [262.567 µs, 375.237 µs]
basic	303.822 µs [291.488 µs, 316.156 µs]
loop	10.436 ms [10.325 ms, 10.546 ms]

pr-commenter · 2025-01-21T18:44:37Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3354
git_commit_date	1737638844	1737642155
git_commit_sha	`ac29d6c`	`89a5993`
release_version	1.46.0-SNAPSHOT~ac29d6cfa4	1.46.0-SNAPSHOT~89a5993f12

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737644522	1737644522
ci_job_id	777762903	777762903
ci_pipeline_id	53800642	53800642
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-nvtssqy9-project-304-concurrent-0-z1sd27ud 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-nvtssqy9-project-304-concurrent-0-z1sd27ud 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~89a5993f12, baseline=1.46.0-SNAPSHOT~ac29d6cfa4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053403
Total [baseline] (8.621 s) : 0, 8620503
Agent [candidate] (1.062 s) : 0, 1062042
Total [candidate] (8.678 s) : 0, 8678111
section iast
Agent [baseline] (1.182 s) : 0, 1182378
Total [baseline] (9.216 s) : 0, 9216298
Agent [candidate] (1.186 s) : 0, 1185746
Total [candidate] (9.197 s) : 0, 9196733
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1181858
Total [baseline] (9.21 s) : 0, 9209821
Agent [candidate] (1.194 s) : 0, 1193533
Total [candidate] (9.191 s) : 0, 9190752
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1176769
Total [baseline] (9.184 s) : 0, 9184218
Agent [candidate] (1.195 s) : 0, 1195197
Total [candidate] (9.261 s) : 0, 9260514

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	iast	1.182 s	128.974 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.182 s	128.455 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.177 s	123.365 ms (11.7%)
Total	tracing	8.621 s	-
Total	iast	9.216 s	595.795 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.21 s	589.318 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.184 s	563.716 ms (6.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	iast	1.186 s	123.704 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.194 s	131.491 ms (12.4%)
Agent	iast_TELEMETRY_OFF	1.195 s	133.154 ms (12.5%)
Total	tracing	8.678 s	-
Total	iast	9.197 s	518.622 ms (6.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.191 s	512.64 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.261 s	582.402 ms (6.7%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~89a5993f12, baseline=1.46.0-SNAPSHOT~ac29d6cfa4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.52 ms) : 0, 714520
BytebuddyAgent [candidate] (718.935 ms) : 0, 718935
GlobalTracer [baseline] (254.796 ms) : 0, 254796
GlobalTracer [candidate] (258.248 ms) : 0, 258248
AppSec [baseline] (56.91 ms) : 0, 56910
AppSec [candidate] (56.622 ms) : 0, 56622
Remote Config [baseline] (735.041 µs) : 0, 735
Remote Config [candidate] (760.468 µs) : 0, 760
Telemetry [baseline] (11.381 ms) : 0, 11381
Telemetry [candidate] (12.354 ms) : 0, 12354
section iast
BytebuddyAgent [baseline] (832.073 ms) : 0, 832073
BytebuddyAgent [candidate] (833.681 ms) : 0, 833681
GlobalTracer [baseline] (245.961 ms) : 0, 245961
GlobalTracer [candidate] (247.579 ms) : 0, 247579
AppSec [baseline] (58.167 ms) : 0, 58167
AppSec [candidate] (58.351 ms) : 0, 58351
IAST [baseline] (21.735 ms) : 0, 21735
IAST [candidate] (21.622 ms) : 0, 21622
Remote Config [baseline] (675.223 µs) : 0, 675
Remote Config [candidate] (666.636 µs) : 0, 667
Telemetry [baseline] (8.767 ms) : 0, 8767
Telemetry [candidate] (8.8 ms) : 0, 8800
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.951 ms) : 0, 831951
BytebuddyAgent [candidate] (840.09 ms) : 0, 840090
GlobalTracer [baseline] (246.055 ms) : 0, 246055
GlobalTracer [candidate] (247.938 ms) : 0, 247938
AppSec [baseline] (58.017 ms) : 0, 58017
AppSec [candidate] (58.603 ms) : 0, 58603
IAST [baseline] (21.358 ms) : 0, 21358
IAST [candidate] (21.925 ms) : 0, 21925
Remote Config [baseline] (668.056 µs) : 0, 668
Remote Config [candidate] (683.344 µs) : 0, 683
Telemetry [baseline] (8.825 ms) : 0, 8825
Telemetry [candidate] (8.974 ms) : 0, 8974
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.137 ms) : 0, 828137
BytebuddyAgent [candidate] (840.855 ms) : 0, 840855
GlobalTracer [baseline] (245.568 ms) : 0, 245568
GlobalTracer [candidate] (249.16 ms) : 0, 249160
AppSec [baseline] (57.914 ms) : 0, 57914
AppSec [candidate] (58.883 ms) : 0, 58883
IAST [baseline] (20.952 ms) : 0, 20952
IAST [candidate] (21.502 ms) : 0, 21502
Remote Config [baseline] (660.189 µs) : 0, 660
Remote Config [candidate] (696.453 µs) : 0, 696
Telemetry [baseline] (8.609 ms) : 0, 8609
Telemetry [candidate] (8.882 ms) : 0, 8882

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~89a5993f12, baseline=1.46.0-SNAPSHOT~ac29d6cfa4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054144
Total [baseline] (10.529 s) : 0, 10529421
Agent [candidate] (1.057 s) : 0, 1057428
Total [candidate] (10.399 s) : 0, 10398724
section appsec
Agent [baseline] (1.192 s) : 0, 1191795
Total [baseline] (10.794 s) : 0, 10793613
Agent [candidate] (1.192 s) : 0, 1191560
Total [candidate] (10.784 s) : 0, 10783764
section iast
Agent [baseline] (1.193 s) : 0, 1192806
Total [baseline] (11.021 s) : 0, 11020599
Agent [candidate] (1.184 s) : 0, 1183981
Total [candidate] (10.982 s) : 0, 10982432
section profiling
Agent [baseline] (1.254 s) : 0, 1254307
Total [baseline] (10.869 s) : 0, 10869066
Agent [candidate] (1.261 s) : 0, 1260764
Total [candidate] (10.758 s) : 0, 10757529

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	appsec	1.192 s	137.651 ms (13.1%)
Agent	iast	1.193 s	138.662 ms (13.2%)
Agent	profiling	1.254 s	200.163 ms (19.0%)
Total	tracing	10.529 s	-
Total	appsec	10.794 s	264.192 ms (2.5%)
Total	iast	11.021 s	491.179 ms (4.7%)
Total	profiling	10.869 s	339.645 ms (3.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	appsec	1.192 s	134.132 ms (12.7%)
Agent	iast	1.184 s	126.553 ms (12.0%)
Agent	profiling	1.261 s	203.336 ms (19.2%)
Total	tracing	10.399 s	-
Total	appsec	10.784 s	385.04 ms (3.7%)
Total	iast	10.982 s	583.709 ms (5.6%)
Total	profiling	10.758 s	358.805 ms (3.5%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~89a5993f12, baseline=1.46.0-SNAPSHOT~ac29d6cfa4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.23 ms) : 0, 713230
BytebuddyAgent [candidate] (717.233 ms) : 0, 717233
GlobalTracer [baseline] (255.029 ms) : 0, 255029
GlobalTracer [candidate] (255.968 ms) : 0, 255968
AppSec [baseline] (56.165 ms) : 0, 56165
AppSec [candidate] (55.563 ms) : 0, 55563
Remote Config [baseline] (741.675 µs) : 0, 742
Remote Config [candidate] (739.868 µs) : 0, 740
Telemetry [baseline] (14.019 ms) : 0, 14019
Telemetry [candidate] (12.77 ms) : 0, 12770
section appsec
BytebuddyAgent [baseline] (733.422 ms) : 0, 733422
BytebuddyAgent [candidate] (733.33 ms) : 0, 733330
GlobalTracer [baseline] (253.597 ms) : 0, 253597
GlobalTracer [candidate] (253.248 ms) : 0, 253248
AppSec [baseline] (171.139 ms) : 0, 171139
AppSec [candidate] (170.989 ms) : 0, 170989
Remote Config [baseline] (666.024 µs) : 0, 666
Remote Config [candidate] (669.526 µs) : 0, 670
Telemetry [baseline] (8.227 ms) : 0, 8227
Telemetry [candidate] (8.566 ms) : 0, 8566
IAST [baseline] (19.46 ms) : 0, 19460
IAST [candidate] (19.46 ms) : 0, 19460
section iast
BytebuddyAgent [baseline] (839.35 ms) : 0, 839350
BytebuddyAgent [candidate] (833.542 ms) : 0, 833542
GlobalTracer [baseline] (248.553 ms) : 0, 248553
GlobalTracer [candidate] (246.573 ms) : 0, 246573
AppSec [baseline] (58.613 ms) : 0, 58613
AppSec [candidate] (58.247 ms) : 0, 58247
Remote Config [baseline] (666.239 µs) : 0, 666
Remote Config [candidate] (654.349 µs) : 0, 654
Telemetry [baseline] (8.849 ms) : 0, 8849
Telemetry [candidate] (8.684 ms) : 0, 8684
IAST [baseline] (21.671 ms) : 0, 21671
IAST [candidate] (21.263 ms) : 0, 21263
section profiling
BytebuddyAgent [baseline] (704.481 ms) : 0, 704481
BytebuddyAgent [candidate] (708.186 ms) : 0, 708186
GlobalTracer [baseline] (348.692 ms) : 0, 348692
GlobalTracer [candidate] (350.891 ms) : 0, 350891
AppSec [baseline] (54.522 ms) : 0, 54522
AppSec [candidate] (54.075 ms) : 0, 54075
Remote Config [baseline] (708.242 µs) : 0, 708
Remote Config [candidate] (711.548 µs) : 0, 712
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.805 ms) : 0, 8805
ProfilingAgent [baseline] (95.195 ms) : 0, 95195
ProfilingAgent [candidate] (95.927 ms) : 0, 95927
Profiling [baseline] (95.221 ms) : 0, 95221
Profiling [candidate] (95.955 ms) : 0, 95955

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-23T14:31:58	2025-01-23T14:38:59
git_branch	master	evanchooly/DEBUG-3354
git_commit_date	1737638844	1737642155
git_commit_sha	`ac29d6c`	`89a5993`
release_version	1.46.0-SNAPSHOT~ac29d6cfa4	1.46.0-SNAPSHOT~89a5993f12
start_time	2025-01-23T14:31:44	2025-01-23T14:38:45

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737643495	1737643495
ci_job_id	777762904	777762904
ci_pipeline_id	53800642	53800642
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-nvtssqy9-project-304-concurrent-1-wtfdi1dk 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-nvtssqy9-project-304-concurrent-1-wtfdi1dk 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~89a5993f12, baseline=1.46.0-SNAPSHOT~ac29d6cfa4
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.988 µs) : 357, 395
.   : milestone, 376,
iast (508.806 µs) : 487, 531
.   : milestone, 509,
iast_FULL (737.475 µs) : 716, 759
.   : milestone, 737,
iast_GLOBAL (558.047 µs) : 535, 581
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (503.183 µs) : 481, 525
.   : milestone, 503,
iast_INACTIVE (451.25 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (489.286 µs) : 467, 511
.   : milestone, 489,
tracing (448.781 µs) : 427, 470
.   : milestone, 449,
section candidate
no_agent (370.825 µs) : 351, 391
.   : milestone, 371,
iast (502.25 µs) : 481, 524
.   : milestone, 502,
iast_FULL (737.462 µs) : 716, 759
.   : milestone, 737,
iast_GLOBAL (553.676 µs) : 531, 576
.   : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (503.258 µs) : 482, 525
.   : milestone, 503,
iast_INACTIVE (450.251 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (491.16 µs) : 469, 513
.   : milestone, 491,
tracing (450.576 µs) : 430, 471
.   : milestone, 451,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	375.988 µs [356.514 µs, 395.463 µs]	-
iast	508.806 µs [486.69 µs, 530.922 µs]	132.818 µs (35.3%)
iast_FULL	737.475 µs [715.802 µs, 759.147 µs]	361.487 µs (96.1%)
iast_GLOBAL	558.047 µs [535.093 µs, 581.001 µs]	182.059 µs (48.4%)
iast_HARDCODED_SECRET_DISABLED	503.183 µs [481.467 µs, 524.899 µs]	127.195 µs (33.8%)
iast_INACTIVE	451.25 µs [430.21 µs, 472.29 µs]	75.262 µs (20.0%)
iast_TELEMETRY_OFF	489.286 µs [467.335 µs, 511.237 µs]	113.298 µs (30.1%)
tracing	448.781 µs [427.458 µs, 470.104 µs]	72.793 µs (19.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	370.825 µs [350.939 µs, 390.712 µs]	-
iast	502.25 µs [480.708 µs, 523.792 µs]	131.424 µs (35.4%)
iast_FULL	737.462 µs [715.651 µs, 759.273 µs]	366.637 µs (98.9%)
iast_GLOBAL	553.676 µs [531.32 µs, 576.033 µs]	182.851 µs (49.3%)
iast_HARDCODED_SECRET_DISABLED	503.258 µs [481.769 µs, 524.746 µs]	132.432 µs (35.7%)
iast_INACTIVE	450.251 µs [429.215 µs, 471.286 µs]	79.425 µs (21.4%)
iast_TELEMETRY_OFF	491.16 µs [469.199 µs, 513.122 µs]	120.335 µs (32.5%)
tracing	450.576 µs [430.185 µs, 470.967 µs]	79.751 µs (21.5%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~89a5993f12, baseline=1.46.0-SNAPSHOT~ac29d6cfa4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.341 ms) : 1321, 1361
.   : milestone, 1341,
appsec (1.743 ms) : 1720, 1767
.   : milestone, 1743,
appsec_no_iast (1.73 ms) : 1704, 1755
.   : milestone, 1730,
iast (1.483 ms) : 1458, 1508
.   : milestone, 1483,
profiling (1.507 ms) : 1483, 1532
.   : milestone, 1507,
tracing (1.481 ms) : 1457, 1505
.   : milestone, 1481,
section candidate
no_agent (1.357 ms) : 1338, 1375
.   : milestone, 1357,
appsec (1.735 ms) : 1712, 1759
.   : milestone, 1735,
appsec_no_iast (1.745 ms) : 1722, 1768
.   : milestone, 1745,
iast (1.507 ms) : 1482, 1531
.   : milestone, 1507,
profiling (1.505 ms) : 1481, 1528
.   : milestone, 1505,
tracing (1.494 ms) : 1469, 1519
.   : milestone, 1494,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.341 ms [1.321 ms, 1.361 ms]	-
appsec	1.743 ms [1.72 ms, 1.767 ms]	402.231 µs (30.0%)
appsec_no_iast	1.73 ms [1.704 ms, 1.755 ms]	388.465 µs (29.0%)
iast	1.483 ms [1.458 ms, 1.508 ms]	142.048 µs (10.6%)
profiling	1.507 ms [1.483 ms, 1.532 ms]	166.137 µs (12.4%)
tracing	1.481 ms [1.457 ms, 1.505 ms]	139.688 µs (10.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.357 ms [1.338 ms, 1.375 ms]	-
appsec	1.735 ms [1.712 ms, 1.759 ms]	378.78 µs (27.9%)
appsec_no_iast	1.745 ms [1.722 ms, 1.768 ms]	388.814 µs (28.7%)
iast	1.507 ms [1.482 ms, 1.531 ms]	150.007 µs (11.1%)
profiling	1.505 ms [1.481 ms, 1.528 ms]	148.065 µs (10.9%)
tracing	1.494 ms [1.469 ms, 1.519 ms]	137.779 µs (10.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3354
git_commit_date	1737638844	1737642155
git_commit_sha	`ac29d6c`	`89a5993`
release_version	1.46.0-SNAPSHOT~ac29d6cfa4	1.46.0-SNAPSHOT~89a5993f12

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1737644071	1737644071
ci_job_id	777762905	777762905
ci_pipeline_id	53800642	53800642
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-qsn5ud32-project-304-concurrent-0-97k0i89o 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-qsn5ud32-project-304-concurrent-0-97k0i89o 6.8.0-1018-aws #19~22.04.1-Ubuntu SMP Wed Oct 9 16:48:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~89a5993f12, baseline=1.46.0-SNAPSHOT~ac29d6cfa4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1479
.   : milestone, 1468,
appsec (2.361 ms) : 2318, 2404
.   : milestone, 2361,
iast (2.112 ms) : 2057, 2167
.   : milestone, 2112,
iast_GLOBAL (2.161 ms) : 2106, 2217
.   : milestone, 2161,
profiling (1.99 ms) : 1945, 2034
.   : milestone, 1990,
tracing (1.946 ms) : 1904, 1988
.   : milestone, 1946,
section candidate
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.359 ms) : 2316, 2403
.   : milestone, 2359,
iast (2.101 ms) : 2047, 2155
.   : milestone, 2101,
iast_GLOBAL (2.144 ms) : 2089, 2200
.   : milestone, 2144,
profiling (1.954 ms) : 1911, 1998
.   : milestone, 1954,
tracing (1.951 ms) : 1909, 1994
.   : milestone, 1951,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.457 ms, 1.479 ms]	-
appsec	2.361 ms [2.318 ms, 2.404 ms]	893.354 µs (60.9%)
iast	2.112 ms [2.057 ms, 2.167 ms]	643.909 µs (43.9%)
iast_GLOBAL	2.161 ms [2.106 ms, 2.217 ms]	693.513 µs (47.2%)
profiling	1.99 ms [1.945 ms, 2.034 ms]	521.622 µs (35.5%)
tracing	1.946 ms [1.904 ms, 1.988 ms]	477.884 µs (32.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.359 ms [2.316 ms, 2.403 ms]	889.049 µs (60.5%)
iast	2.101 ms [2.047 ms, 2.155 ms]	630.839 µs (42.9%)
iast_GLOBAL	2.144 ms [2.089 ms, 2.2 ms]	674.24 µs (45.9%)
profiling	1.954 ms [1.911 ms, 1.998 ms]	483.93 µs (32.9%)
tracing	1.951 ms [1.909 ms, 1.994 ms]	480.976 µs (32.7%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~89a5993f12, baseline=1.46.0-SNAPSHOT~ac29d6cfa4
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.232 s) : 15232000, 15232000
.   : milestone, 15232000,
appsec (15.134 s) : 15134000, 15134000
.   : milestone, 15134000,
iast (18.743 s) : 18743000, 18743000
.   : milestone, 18743000,
iast_GLOBAL (18.279 s) : 18279000, 18279000
.   : milestone, 18279000,
profiling (15.032 s) : 15032000, 15032000
.   : milestone, 15032000,
tracing (14.977 s) : 14977000, 14977000
.   : milestone, 14977000,
section candidate
no_agent (15.438 s) : 15438000, 15438000
.   : milestone, 15438000,
appsec (15.132 s) : 15132000, 15132000
.   : milestone, 15132000,
iast (18.698 s) : 18698000, 18698000
.   : milestone, 18698000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
.   : milestone, 17885000,
profiling (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
tracing (15.058 s) : 15058000, 15058000
.   : milestone, 15058000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.232 s [15.232 s, 15.232 s]	-
appsec	15.134 s [15.134 s, 15.134 s]	-98.0 ms (-0.6%)
iast	18.743 s [18.743 s, 18.743 s]	3.511 s (23.1%)
iast_GLOBAL	18.279 s [18.279 s, 18.279 s]	3.047 s (20.0%)
profiling	15.032 s [15.032 s, 15.032 s]	-200.0 ms (-1.3%)
tracing	14.977 s [14.977 s, 14.977 s]	-255.0 ms (-1.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.438 s [15.438 s, 15.438 s]	-
appsec	15.132 s [15.132 s, 15.132 s]	-306.0 ms (-2.0%)
iast	18.698 s [18.698 s, 18.698 s]	3.26 s (21.1%)
iast_GLOBAL	17.885 s [17.885 s, 17.885 s]	2.447 s (15.9%)
profiling	15.009 s [15.009 s, 15.009 s]	-429.0 ms (-2.8%)
tracing	15.058 s [15.058 s, 15.058 s]	-380.0 ms (-2.5%)

evanchooly · 2025-01-21T19:03:09Z

This feels clean enough now. There are incidental changes that could be debated. The code feels cleaner with them but I could be convinced.

...ugger/debugger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/DebuggerContext.java

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/DebuggerTransformer.java

.../agent-debugger/src/main/java/com/datadog/debugger/codeorigin/DefaultCodeOriginRecorder.java

...gent-debugger/src/main/java/com/datadog/debugger/instrumentation/CodeOriginInstrumentor.java

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/instrumentation/MethodInfo.java

...a-agent/agent-debugger/src/test/java/com/datadog/debugger/agent/DebuggerTransformerTest.java

…ID is present include session_id tag on those probes

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/Snapshot.java

remove premature ID generation in Snapshot

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

evanchooly added type: enhancement comp: debugger Dynamic Instrumentation labels Jan 21, 2025

evanchooly added 2 commits January 21, 2025 14:10

Updates for splitting code origins and snapshots

4d57894

rebase cleanups

1855300

evanchooly force-pushed the evanchooly/DEBUG-3354 branch from e03663f to 1855300 Compare January 21, 2025 19:19

evanchooly marked this pull request as ready for review January 21, 2025 19:21

evanchooly requested a review from a team as a code owner January 21, 2025 19:21

evanchooly requested review from jpbempel and removed request for a team January 21, 2025 19:21

jpbempel reviewed Jan 22, 2025

View reviewed changes

evanchooly added 3 commits January 22, 2025 09:31

PR clean ups

a0a9ae9

make code origin initiated log probes only snapshot when the session …

1a079eb

…ID is present include session_id tag on those probes

add snapshot_id to spans again

81ffe2c

jpbempel reviewed Jan 22, 2025

View reviewed changes

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/Snapshot.java Outdated Show resolved Hide resolved

evanchooly added 2 commits January 22, 2025 16:31

remove debug

df6b022

remove premature ID generation in Snapshot

that should be transient

7376748

jpbempel approved these changes Jan 23, 2025

View reviewed changes

Merge branch 'master' into evanchooly/DEBUG-3354

89a5993

evanchooly enabled auto-merge (squash) January 23, 2025 14:23

evanchooly disabled auto-merge January 23, 2025 15:13

evanchooly enabled auto-merge (squash) January 23, 2025 15:13

evanchooly added type: enhancement and removed type: enhancement labels Jan 23, 2025

evanchooly merged commit 991929d into master Jan 23, 2025
178 of 179 checks passed

evanchooly deleted the evanchooly/DEBUG-3354 branch January 23, 2025 15:19

github-actions bot added this to the 1.46.0 milestone Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify code origins. Separate out snapshot generation. #8263

Simplify code origins. Separate out snapshot generation. #8263

evanchooly commented Jan 21, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Jan 21, 2025 •

edited

Loading

pr-commenter bot commented Jan 21, 2025 •

edited

Loading

evanchooly commented Jan 21, 2025

Simplify code origins. Separate out snapshot generation. #8263

Simplify code origins. Separate out snapshot generation. #8263

Conversation

evanchooly commented Jan 21, 2025 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Jan 21, 2025 • edited Loading

Debugger benchmarks

Parameters

Summary

pr-commenter bot commented Jan 21, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

evanchooly commented Jan 21, 2025

evanchooly commented Jan 21, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Jan 21, 2025 •

edited

Loading

pr-commenter bot commented Jan 21, 2025 •

edited

Loading