Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test optimization] Report code coverage relative to the repository root, not the project's root dir or working directory #4903

Merged

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Nov 18, 2024

What does this PR do?

The comparison between git metadata and code coverage is more likely to work if code coverage is reported relative to the repository root rather than the working directory / root dir.

Motivation

Increase likelihood that TIA works.

Plugin Checklist

  • Unit tests.

Copy link

github-actions bot commented Nov 18, 2024

Overall package size

Self size: 8.03 MB
Deduped: 94.53 MB
No deduping: 94.87 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Nov 18, 2024

Benchmarks

Benchmark execution time: 2024-11-19 12:16:32

Comparing candidate commit 48e3686 in PR branch juan-fernandez/report-code-coverage-files-from-repo with baseline commit 2072a1f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 256 metrics, 10 unstable metrics.

@juan-fernandez juan-fernandez marked this pull request as ready for review November 19, 2024 12:08
@juan-fernandez juan-fernandez requested a review from a team as a code owner November 19, 2024 12:08
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.14%. Comparing base (61c5a32) to head (48e3686).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4903       +/-   ##
===========================================
+ Coverage   69.93%   81.14%   +11.20%     
===========================================
  Files         120      284      +164     
  Lines        4025    13202     +9177     
===========================================
+ Hits         2815    10713     +7898     
- Misses       1210     2489     +1279     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@juan-fernandez juan-fernandez merged commit 920d2a2 into master Nov 19, 2024
235 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/report-code-coverage-files-from-repo branch November 19, 2024 16:12
rochdev pushed a commit that referenced this pull request Nov 19, 2024
…oot, not the project's root dir or working directory (#4903)
@rochdev rochdev mentioned this pull request Nov 19, 2024
rochdev pushed a commit that referenced this pull request Nov 19, 2024
…oot, not the project's root dir or working directory (#4903)
@rochdev rochdev mentioned this pull request Nov 19, 2024
rochdev pushed a commit that referenced this pull request Nov 19, 2024
…oot, not the project's root dir or working directory (#4903)
rochdev pushed a commit that referenced this pull request Nov 19, 2024
…oot, not the project's root dir or working directory (#4903)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants