Search for jest libraries by exact match rather than contains #4911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces
contains
with real equality for deciding which modules should be bypassing the jest require engine.Motivation
In our app, we utilize the library office-addin-mock during our test process, to mock our interactions with office addin code.
If we follow its dependency tree through
office-addin-mock
->office-addin-usage-data
->applicationinsights
->diagnostic-channel-publishers
, one can find that indiagnostic-channel-publishers
, we import our own, local version of winston calledwinston.pub
.Because of this
contains
logic, this causes the import of./winston.pub
(and any other similarly-named local modules) to utilizeshimmer._requireCoreModule
instead ofrequireModuleOrMock
from jest. The shimmer method does not work with this local import, so you end up with an error message like the following when attempting to importoffice-addin-mock
:My educated guess is that this logic wasn't really meant to be a
contains
but I'm open to other suggestions as to how to solve this.