Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracer): [SVLS-5264] S3 CopyObject span pointers #10758

Merged

Conversation

apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Sep 23, 2024

Adding span pointers for the S3 CopyObject operation.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 23, 2024

CODEOWNERS have been resolved as:

releasenotes/notes/span-pointers-aws-s3-copyobject-3d8ab886b32695b9.yaml  @DataDog/apm-python
ddtrace/_trace/utils_botocore/span_pointers.py                          @DataDog/apm-sdk-api-python
tests/tracer/utils_botocore/test_span_pointers.py                       @DataDog/apm-sdk-api-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 23, 2024

Datadog Report

Branch report: aleksandr.pasechnik/svls-5264-s3-copyobject-pointers
Commit report: 602f569
Test service: dd-trace-py

✅ 0 Failed, 966 Passed, 320 Skipped, 28m 28.12s Total duration (9m 2.37s time saved)

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5264-s3-copyobject-pointers branch from 48cdcb5 to 284358b Compare September 23, 2024 16:29
@apiarian-datadog apiarian-datadog marked this pull request as ready for review September 23, 2024 16:32
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner September 23, 2024 16:32
@apiarian-datadog
Copy link
Contributor Author

confirmed that this (along with #10690 ) results in correct span pointers on copy-object requests.

@pr-commenter
Copy link

pr-commenter bot commented Sep 23, 2024

Benchmarks

Benchmark execution time: 2024-09-23 20:39:19

Comparing candidate commit 602f569 in PR branch aleksandr.pasechnik/svls-5264-s3-copyobject-pointers with baseline commit d4a7535 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 342 metrics, 48 unstable metrics.

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5264-s3-copyobject-pointers branch from ec6c10a to 460bede Compare September 23, 2024 19:34
@apiarian-datadog apiarian-datadog enabled auto-merge (squash) September 23, 2024 19:38
@apiarian-datadog apiarian-datadog enabled auto-merge (squash) September 23, 2024 20:01
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5264-s3-copyobject-pointers branch from 460bede to 602f569 Compare September 23, 2024 20:02
@apiarian-datadog apiarian-datadog merged commit 3bffd02 into main Sep 23, 2024
573 of 574 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/svls-5264-s3-copyobject-pointers branch September 23, 2024 20:41
mabdinur pushed a commit that referenced this pull request Sep 25, 2024
Adding span pointers for the S3 CopyObject operation.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants