-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracer): [SVLS-5264] S3 CopyObject span pointers #10758
feat(tracer): [SVLS-5264] S3 CopyObject span pointers #10758
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 966 Passed, 320 Skipped, 28m 28.12s Total duration (9m 2.37s time saved) |
48cdcb5
to
284358b
Compare
confirmed that this (along with #10690 ) results in correct span pointers on copy-object requests. |
BenchmarksBenchmark execution time: 2024-09-23 20:39:19 Comparing candidate commit 602f569 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 342 metrics, 48 unstable metrics. |
ec6c10a
to
460bede
Compare
460bede
to
602f569
Compare
Adding span pointers for the S3 CopyObject operation. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Adding span pointers for the S3 CopyObject operation.
Checklist
Reviewer Checklist