Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move PyPI artifact uploading to GitLab #10760

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Sep 23, 2024

Moving the artifact uploading to GitLab means we can include other GitLab validations as requirements to uploading to PyPI.

We have validated this by first having the pipeline upload to test.pypi.org.

This was enabled for the 2.12.2 release, and we can validate the artifacts uploaded were the same:

All files were downloaded, and the sha256 sums were validated to be the same.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 23, 2024
@brettlangdon brettlangdon requested review from a team as code owners September 23, 2024 17:47
@brettlangdon brettlangdon enabled auto-merge (squash) September 23, 2024 17:47
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/build_deploy.yml                                      @DataDog/python-guild @DataDog/apm-core-python
.gitlab/release.yml                                                     @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Sep 23, 2024

Benchmarks

Benchmark execution time: 2024-09-23 18:21:41

Comparing candidate commit 0267762 in PR branch brettlangdon/gitlab.release with baseline commit 5546c23 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 356 metrics, 48 unstable metrics.

Copy link
Contributor

@erikayasuda erikayasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to backport this to <=2.13 then?

@brettlangdon brettlangdon merged commit 219ecbd into main Sep 23, 2024
618 of 619 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/gitlab.release branch September 23, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants