Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move PyPI artifact uploading to GitLab #10760

Merged
merged 1 commit into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions .github/workflows/build_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,25 +77,3 @@ jobs:
run: python $GITHUB_WORKSPACE/tests/smoke_test.py
# Move out of the workspace to avoid importing ddtrace from the source
working-directory: /

upload_pypi:
needs:
- build_wheels
- test_alpine_sdist
runs-on: ubuntu-latest
if: (github.event_name == 'release' && github.event.action == 'published')
steps:
- uses: actions/download-artifact@v4
with:
path: dist
merge-multiple: true

- uses: pypa/gh-action-pypi-publish@release/v1
with:
user: __token__
password: ${{ secrets.PYPI_TOKEN }}
# To test: repository_url: https://test.pypi.org/legacy/
# Setting skip_existing will prevent the deploy from erring out early
# due to a duplicate wheel being present which will ensure that the rest
# of the wheels will be uploaded if some are uploaded manually.
skip_existing: true
18 changes: 9 additions & 9 deletions .gitlab/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ variables:
- pywheels/*.whl
- pywheels/*.tar.gz

release_pypi_test:
# Can be used to validate uploading of artifacts
# release_pypi_test:
# extends: .release_pypi
# dependencies: [ "download_ddtrace_artifacts" ]
# variables:
# PYPI_REPOSITORY: testpypi

release_pypi_prod:
extends: .release_pypi
dependencies: [ "download_ddtrace_artifacts" ]
variables:
PYPI_REPOSITORY: testpypi

# TODO: Replace GitHub Action PyPI upload with this job
# release_pypi_prod:
# extends: .release_pypi
# needs: [ "release_pypi_test" ]
# variables:
# PYPI_REPOSITORY: pypi
PYPI_REPOSITORY: pypi
Loading