-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(testing): fail the build if the git tree is dirty #5701
Merged
emmettbutler
merged 23 commits into
1.x
from
emmett.butler/automate-nightly-lockfile-upgrades
May 2, 2023
Merged
chore(testing): fail the build if the git tree is dirty #5701
emmettbutler
merged 23 commits into
1.x
from
emmett.butler/automate-nightly-lockfile-upgrades
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yun-Kim
previously approved these changes
Apr 28, 2023
mabdinur
previously approved these changes
May 1, 2023
P403n1x87
approved these changes
May 2, 2023
mabdinur
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes CI test builds fail if they leave a dirty git tree. Combined with the fact that the nightly build recompiles requirements files, this will result in a failing nightly build when a
latest
dependency in the Riotfile has a new version released. The failure is accompanied by a message suggesting a requirements lockfile update.Checklist
Reviewer Checklist