Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): fail the build if the git tree is dirty #5701

Merged
merged 23 commits into from
May 2, 2023

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Apr 28, 2023

This change makes CI test builds fail if they leave a dirty git tree. Combined with the fact that the nightly build recompiles requirements files, this will result in a failing nightly build when a latest dependency in the Riotfile has a new version released. The failure is accompanied by a message suggesting a requirements lockfile update.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • PR description includes explicit acknowledgement/acceptance of the performance implications of this PR as reported in the benchmarks PR comment.
  • update riot dependency once feat: ensure hash consistency between lockfile and venv riot#207 is merged

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.

@emmettbutler emmettbutler requested a review from a team as a code owner April 28, 2023 18:53
@emmettbutler emmettbutler marked this pull request as draft April 28, 2023 18:54
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 28, 2023
@emmettbutler emmettbutler marked this pull request as ready for review April 28, 2023 18:59
Yun-Kim
Yun-Kim previously approved these changes Apr 28, 2023
@emmettbutler emmettbutler marked this pull request as draft April 28, 2023 20:30
mabdinur
mabdinur previously approved these changes May 1, 2023
@emmettbutler emmettbutler dismissed stale reviews from mabdinur and Yun-Kim via 2a2fc5d May 1, 2023 16:56
@pr-commenter
Copy link

pr-commenter bot commented May 1, 2023

Benchmarks

Comparing candidate commit fab3339 in PR branch emmett.butler/automate-nightly-lockfile-upgrades with baseline commit bfe0695 in branch 1.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 94 cases.

@emmettbutler emmettbutler marked this pull request as ready for review May 2, 2023 15:06
@emmettbutler emmettbutler requested review from Yun-Kim and mabdinur May 2, 2023 15:06
@emmettbutler emmettbutler enabled auto-merge (squash) May 2, 2023 17:06
@emmettbutler emmettbutler merged commit 834db3d into 1.x May 2, 2023
@emmettbutler emmettbutler deleted the emmett.butler/automate-nightly-lockfile-upgrades branch May 2, 2023 17:08
@github-actions github-actions bot added this to the v1.14.0 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants