feat: ensure hash consistency between lockfile and venv #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P403n1x87
reviewed
May 2, 2023
brettlangdon
reviewed
May 2, 2023
emmettbutler
changed the title
emmettbutler
requested review from
brettlangdon,
P403n1x87,
majorgreys and
ZStriker19
16 tasks
brettlangdon
approved these changes
May 2, 2023
hacking give prefixes even when no packages remove debug prints revert unnecessary changes undo imports regression test undo release note
emmettbutler
force-pushed
the
emmett.butler/hash-consistency
branch
from
036c769 to
2ba7452
Compare
brettlangdon
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue observable in this test run in which riot generated a requirements lockfile for a
Venvinstance other than the one it was running tests for. This behavior was happening due to riot logic that skippedVenvinstances withpkgs == Nonewhile preparing the environment, but not while running tests. Thus the fix is to stop riot from ignoringpkgs-lessVenvs in all cases.Note these two lines of output from the example test run:
This illustrates the mismatch.
RIOT_VENV_HASHis the hash of the environment in which the command will be run, and for which the lockfile should be generated. Theprepare()function had been ignoring that environment and instead preparing an environment for one of its ancestors.