Implement latest_major and lastest_minor tag for docker init container
#3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
force-pushed
the
tonycthsu/docker-init-tags
branch
2 times, most recently
from
63417b9
to
be92864
Compare
TonyCTHsu
force-pushed
the
tonycthsu/docker-init-tags
branch
from
be92864
to
eda38c2
Compare
anmarchenko
approved these changes
May 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3643 +/- ##
==========================================
- Coverage 98.10% 98.10% -0.01%
==========================================
Files 1225 1232 +7
Lines 72464 72552 +88
Branches 3439 3443 +4
==========================================
+ Hits 71094 71179 +85
- Misses 1370 1373 +3 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
force-pushed
the
tonycthsu/docker-init-tags
branch
from
b05862d
to
3ba4401
Compare
|
Out of curiosity, who/what is the consumer of these images? |
marcotc
reviewed
May 14, 2024
Comment on lines
+16
to
+17
| max_retries = 60 | ||
| interval = 60 |
There was a problem hiding this comment.
Do we need wait a whole minute before retrying?
I ask in case .gitlab/check_gem_presence.rb is ever something a human is actively waiting on. If so, I suggest reducing the interval to something like 10 seconds (and increasing max_retries to match).
There was a problem hiding this comment.
We can change this frequency in the future.
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Jun 4, 2024
* master: (22 commits) Remove experimental warning from OpenTelemetry.md Remove latest tag on docker images add installer system tests Extract trace id format helper method (DataDog#3670) Remaps http status code tag for otel span for trace metrics (DataDog#3664) Update .github/labeler.yml Use 3.20 rb -> ruby Add a note about `use` vs `instrument` GitHub: Update labeller bot with new products Update lockfiles for release 2.0.0.rc1 Bump version 2.0.0.beta2 to 2.0.0.rc1 Add 2.0.0.rc1 to CHANGELOG.md chore(lib-injection): update base image to alpine 3.18.6 Apply suggestions from code review Revert "DEBUG-2334 Add Debugger component (DataDog#3640)" Implement `latest_major` and `lastest_minor` tag for docker init container (DataDog#3643) Build oci package Update `rexml` (DataDog#3656) Remove bundler cache in for `setup-ruby` step and pin bundler and rubygem version ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently, images for docker init container are tagged with the semantic version (ie:
v2.1.1) andlatest.This PR would add 2 more tags
v2v2.1