Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport adding latest_major and latest_minor tags #3644

Merged
merged 5 commits into from
May 23, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented May 14, 2024

This PR backports #3643 to 1.x-stable

In addition, it does not tagged latest on this branch

@TonyCTHsu TonyCTHsu added this to the 1.23.1 milestone May 14, 2024
@TonyCTHsu TonyCTHsu changed the title Backport https://github.com/DataDog/dd-trace-rb/pull/3643 Backport #3643 May 14, 2024
@TonyCTHsu TonyCTHsu changed the title Backport #3643 Backport adding latest_major and latest_minor May 14, 2024
@TonyCTHsu TonyCTHsu changed the title Backport adding latest_major and latest_minor Backport adding latest_major and latest_minor tags May 14, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review May 14, 2024 10:50
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner May 14, 2024 10:50
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/backport-docker-init-tags branch from 41237df to e0ac218 Compare May 14, 2024 12:55
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

FYI, this is likely to be removed and replaced with a generic, centralised script at a later date (by @randomanderson). The question then will be whether the published gems are used as the source of truth, or a more more generic approach (like git tags)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (cf264ae) to head (e0ac218).
Report is 10 commits behind head on 1.x-stable.

Additional details and impacted files
@@             Coverage Diff             @@
##           1.x-stable    #3644   +/-   ##
===========================================
  Coverage       98.24%   98.24%           
===========================================
  Files            1255     1255           
  Lines           74651    74651           
  Branches         3544     3544           
===========================================
  Hits            73342    73342           
  Misses           1309     1309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu merged commit e9dcf8e into 1.x-stable May 23, 2024
195 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/backport-docker-init-tags branch May 23, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants