Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update-gemfiles workflow permissions #3878

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

lloeki
Copy link
Contributor

@lloeki lloeki commented Aug 30, 2024

What does this PR do?

Fix update-gemfiles workflow permissions

Motivation:

No permission is declared in the workflow file, when a switch to a more restrictive global setting would cause the workflow to fail.

Additional Notes:

None.

JIRA:

How to test the change?

Unsure? Have a question? Request a review!

No permission is declared in the workflow file, when a switch to a
more restrictive global setting would cause the workflow to fail.
@lloeki lloeki requested a review from a team as a code owner August 30, 2024 11:06
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Aug 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (18dafe3) to head (c95a7fe).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3878   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files        1277     1277           
  Lines       76394    76394           
  Branches     3744     3744           
=======================================
+ Hits        74762    74763    +1     
+ Misses       1632     1631    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Aug 30, 2024

Benchmarks

Benchmark execution time: 2024-08-30 11:40:14

Comparing candidate commit c95a7fe in PR branch fix-update-gemfiles-permissions with baseline commit 72f2d40 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@lloeki lloeki merged commit 47eb184 into master Aug 30, 2024
165 of 168 checks passed
@lloeki lloeki deleted the fix-update-gemfiles-permissions branch August 30, 2024 12:25
@github-actions github-actions bot added this to the 2.4.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants