-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport: Fixes to restore CI in 1.x branch #3909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No permission is declared in the workflow file, when a switch to a more restrictive global setting would cause the workflow to fail.
github-actions
bot
added
the
dev/github
Github repository maintenance and automation
label
Sep 12, 2024
…avoid deb and rpm)
github-actions
bot
removed
the
dev/github
Github repository maintenance and automation
label
Sep 12, 2024
marcotc
changed the title
Backport: Fix update-gemfiles workflow permissions
Backport: Fix update-gemfiles workflow permissions & Onboarding and k8s lib injection tests: Remove deprecated scenarios
Sep 12, 2024
We need write permissions to push images to registry.
marcotc
changed the title
Backport: Fix update-gemfiles workflow permissions & Onboarding and k8s lib injection tests: Remove deprecated scenarios
Backport: Fixes to restore CI in 1.x branch
Sep 12, 2024
Pin passenger version for integration test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x-stable #3909 +/- ##
===========================================
Coverage 98.25% 98.25%
===========================================
Files 1259 1259
Lines 74967 74966 -1
Branches 3570 3570
===========================================
Hits 73657 73657
+ Misses 1310 1309 -1 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #3878 & #3791 & #3879 to ensure CI continues working for the
1.x-stable
.