Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS-6052] Add HTTP intake site address shortcode for Zscaler #2082

Closed
wants to merge 1 commit into from
Closed

[DOCS-6052] Add HTTP intake site address shortcode for Zscaler #2082

wants to merge 1 commit into from

Conversation

maycmlee
Copy link
Contributor

What does this PR do?

Adds the site address shortcode so the API endpoint changes based on the region.

Motivation

SE request

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@maycmlee maycmlee requested review from BoyangHuang and a team as code owners August 15, 2023 20:01
@maycmlee maycmlee requested a review from a team August 16, 2023 14:17
buraizu
buraizu approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanmadams nathanmadams added the assets/no-deploy Prevents APW from deploying this PR in staging label Jan 30, 2024
@maycmlee
Copy link
Contributor Author

Closing out in favor of: #2455

@maycmlee maycmlee closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraizu buraizu buraizu approved these changes

@BoyangHuang BoyangHuang Awaiting requested review from BoyangHuang BoyangHuang is a code owner

Assignees
No one assigned
Labels
assets/no-deploy Prevents APW from deploying this PR in staging changelog/no-changelog do-not-merge/WIP docs/approved ecosystems/review-requested product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maycmlee @buraizu @nathanmadams