Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-6052] Add region param for Zscaler endpoint #2455

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

maycmlee
Copy link
Contributor

@maycmlee maycmlee commented Jul 31, 2024

What does this PR do?

Adds the region param for the Zscaler endpoint so that it changes to the correct URL for different regions.

Motivation

DOCS-6052

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@maycmlee
Copy link
Contributor Author

maycmlee commented Aug 1, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 1, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 0s.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Aug 1, 2024

MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build took longer than expected. The current limit for the base branch 'master' is 120 minutes.

If you need support, contact us on Slack #devflow with those details!

@maycmlee
Copy link
Contributor Author

maycmlee commented Aug 1, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 1, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 0s.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Aug 1, 2024

MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build took longer than expected. The current limit for the base branch 'master' is 120 minutes.

If you need support, contact us on Slack #devflow with those details!

@maycmlee maycmlee merged commit 2e50cb4 into master Aug 1, 2024
27 of 28 checks passed
@maycmlee maycmlee deleted the may/zscaler-endpoint-region-param branch August 1, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants