RFC: Allow verify trace-protobuf to continue on error #275
Conversation
**What does this PR do?** This PR changes the "Verify trace-protobuf" github action to include "continue-on-error", so that unrelated PRs don't get marked as having failed CI when this action triggers. Additionally, it makes use of the `mainmatter/continue-on-error-comment@v1` action to turn these errors into a comment that gets added into the PR, so that we don't miss that this action failed -- we just make failures less noisy. **Motivation:** I like having a green CI, and it's annoying to have a red CI because this action failed, since for many libdatadog PRs we don't care (e.g. this only impacts the serverless agent). Thus, I decided to experiment with this alternative approach. As the PR title says -- comments welcome! Do you think this is reasonable? **Additional Notes:** N/A **How to test the change?** I'm hoping the action will start triggering for this PR itself, so we can see it running.
|
It looks like the |
There was a problem hiding this comment.
https://github.com/DataDog/libdatadog/actions/runs/6638247018
It looks like the action is invalid
|
I added the action with the specific hash in this PR here https://github.com/DataDog/libdatadog/settings/actions |
|
Ahh, thanks for spotting that -- I had added with the |
|
It seems it has run now -- but doesn't output anything because it only runs on new PRs, not on branch updates ( https://github.com/DataDog/libdatadog/actions/runs/6642718147/job/18048114414?pr=275 ). My suggestion is: Let's merge this in, and then right after I can open a tiny PR with a dummy fix to verify it's working fine. If it is, it stays, if not, I'll open a PR to revert it (or tweak it, if needed). |
Please ignore this PR. Context: #275 (comment)
**What does this PR do?** In #275, I've attempted to add the `mainmatter/continue-on-error-comment` github action which replaces a CI error with a comment, so that it's less annoying when "Verify trace-protobuf" fails and we don't get a ugly red cross on every PR. My first attempt didn't work! I missed that I needed to change the trigger for the verify action to be on pull requests, not on pushes. This PR fixes that, and we should see the action comment show up as an example. **Motivation:** Fix #275. **Additional Notes:** N/A **How to test the change?** See the comment that will show up!
|
Update: Almost got it! #280 has a tiny fix and otherwise this seems to work fine. |
What does this PR do?
This PR changes the "Verify trace-protobuf" github action to include "continue-on-error", so that unrelated PRs don't get marked as having failed CI when this action triggers.
Additionally, it makes use of the
mainmatter/continue-on-error-comment@v1action to turn these errors into a comment that gets added into the PR, so that we don't miss that this action failed -- we just make failures less noisy.Motivation:
I like having a green CI, and it's annoying to have a red CI because this action failed, since for many libdatadog PRs we don't care (e.g. this only impacts the serverless agent).
Thus, I decided to experiment with this alternative approach. As the PR title says -- comments welcome! Do you think this is reasonable?
Additional Notes:
N/A
How to test the change?
I'm hoping the action will start triggering for this PR itself, so we can see it running.
For Reviewers
@DataDog/security-design-and-guidance.