-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rustls version to 0.23 #459
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
+ Coverage 70.46% 70.48% +0.01%
==========================================
Files 205 205
Lines 27936 27934 -2
==========================================
+ Hits 19685 19688 +3
+ Misses 8251 8246 -5
|
2821933
to
182f14c
Compare
5e88a14
to
35f955c
Compare
We were running into symbol issues with older rustls versions, see briansmith/ring#1808. Note that the new rustls version requires nasm to be installed on windows, so we install it in CI. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
BenchmarksComparisonParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.
CandidateCandidate benchmark detailsGroup 1
Warnings
BaselineBaseline benchmark detailsGroup 1
Warnings
|
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
b430970
to
590c412
Compare
…But aws-lc-sys is actually preferable. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.
Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.