Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GFp_armcap_P/ring_core_*_OPENSSL_armcap_P a hidden symbol #1808

Closed
briansmith opened this issue Nov 21, 2023 · 3 comments
Closed

Make GFp_armcap_P/ring_core_*_OPENSSL_armcap_P a hidden symbol #1808

briansmith opened this issue Nov 21, 2023 · 3 comments
Milestone
0.17.6

Comments

@briansmith
Copy link
Owner

When one tries to create a --crate-type=staticlib or similar, GFp_armcap_P will be exported from the staticlib. If that static library is then linked into Rust program that depends on ring, the user will get "duplicate symbol" errors for this symbol. The hypothesis is that this is due to the symbol not having visibility=hidden.

This symbol is special because it is prefixed_export! which means it gets a #[export_name = "..."] annotation. Other symbols aren't so affected on ARM because they are defined in C and are given visibility=hidden.

On non-ARM/Aarch64/x86/x86-64 targets, bn_mul_mont is affected in the same way for the same reason. That should be rectified as well. Basically we need to remove prefixed_export! and all its uses.
@briansmith
Copy link
Owner Author

Related Rust issues/enhancement requests:

This was referenced Nov 21, 2023
Open
Closed
@briansmith
Copy link
Owner Author

PR #1823 attempts to address this.

@briansmith briansmith added this to the 0.17.6 milestone Nov 28, 2023
@briansmith
Copy link
Owner Author

Fixed (I speculate) in 0.17.6 by PR #1823. It would be great to get confirmation that this is indeed fixed.

bwoebi added a commit to DataDog/libdatadog that referenced this issue May 29, 2024
@bwoebi
Bump rustls version to 0.23
068ab39 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi mentioned this issue May 29, 2024
Merged
bwoebi added a commit to DataDog/libdatadog that referenced this issue May 29, 2024
@bwoebi
Bump rustls version to 0.23
89550c3 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit to DataDog/libdatadog that referenced this issue May 29, 2024
@bwoebi
Bump rustls version to 0.23
0d226cd 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit to DataDog/libdatadog that referenced this issue May 30, 2024
@bwoebi
Bump rustls version to 0.23
64402f4 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit to DataDog/libdatadog that referenced this issue May 30, 2024
@bwoebi
Bump rustls version to 0.23
0c8e4a0 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit to DataDog/libdatadog that referenced this issue May 30, 2024
@bwoebi
Bump rustls version to 0.23
e43610b 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit to DataDog/libdatadog that referenced this issue May 30, 2024
@bwoebi
Bump rustls version to 0.23
69d53ce 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit to DataDog/libdatadog that referenced this issue May 30, 2024
@bwoebi
Bump rustls version to 0.23
ecb48da 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit to DataDog/libdatadog that referenced this issue May 30, 2024
@bwoebi
Bump rustls version to 0.23
2821933 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit to DataDog/libdatadog that referenced this issue May 30, 2024
@bwoebi
Bump rustls version to 0.23
182f14c 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit to DataDog/libdatadog that referenced this issue Jul 5, 2024
@bwoebi
Bump rustls version to 0.23
c229c13 
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit to DataDog/libdatadog that referenced this issue Jul 9, 2024
@bwoebi
Bump rustls version to 0.23 (#459)
25f5c42 
* Bump rustls version to 0.23

We were running into symbol issues with older rustls versions, see briansmith/ring#1808.

Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* Require at least aws-lc-rs 1.8

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* Use ring instead of aws-lc-sys due to aws/aws-lc-rs#453

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* Use ring for windows only, as aws-lc-sys has link issues on windows. But aws-lc-sys is actually preferable.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

---------

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.17.6
Development

No branches or pull requests
1 participant
@briansmith