ci: build OpenTelemetryApi.xcframework #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshnj
force-pushed
the
ganeshnj/ci/build-xcframework
branch
from
eb5fc87 to
578c025
Compare
maciejburda
reviewed
Jan 30, 2024
Comment on lines
+3
to
+8
| on: | ||
| push: | ||
| branches: [ "main" ] | ||
| pull_request: | ||
| branches: [ "main" ] | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Just to open the discussion:
It seems like we've taken simplified path without develop branch. Does it make sense to have it?
Are we going to version this?
There was a problem hiding this comment.
No, there are no versions of this tooling just like the harvester. Also, if ever come and want to, we can aways do. Two way door decision.
maciejburda
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
OpenTelemetryApi.xcframework is first step of supporting OpenTelemetryApi for Cocoapods and Carthage.
How?
Follows the RFC
The final artifact is uploaded as part of PR artifacts.