CI is not being executed against Rails 7.1 stable (and probably 7.1 compatibility is broken on main) #106
Comments
tagliala
added a commit
to tagliala/database_cleaner-active_record
that referenced
this issue
Jun 10, 2024
Stable builds: - Test against Ruby 3.3 stable - Test against Rails 7.1 stable - Test against Rails 7.2 beta Experimental builds: - Test against Rails edge (previously: 7.1, ref: DatabaseCleaner#106) - Test against Ruby head Fixes: - Fix sqlite3 dependency on old Rails versions Updates: - Update GitHub actions Readability: - Sort and group inclusion and exclusions in CI matrix
tagliala
changed the title
tagliala
added a commit
to tagliala/database_cleaner-active_record
that referenced
this issue
Jun 10, 2024
ActiveRecord: - 5.x: `SchemaMigration.table_name` - 6.x, 7.0, 7.1: `Base.connection.schema_migration.table_name` - 7.2: `Base.connection_pool.schema_migration.table_name` Close DatabaseCleaner#106
tagliala
added a commit
to tagliala/database_cleaner-active_record
that referenced
this issue
Jun 10, 2024
Also: - Invert the logic to make the conditional more readable - Add "alpha" to version to include pre-releases ActiveRecord: - 7.2: `Base.connection_pool.schema_migration.table_name` - 7.1, 7.0, 6.x: `Base.connection.schema_migration.table_name` - 5.x: `SchemaMigration.table_name` Close DatabaseCleaner#106
tagliala
added a commit
to tagliala/database_cleaner-active_record
that referenced
this issue
Jun 10, 2024
Also: - Invert the logic to make the conditional more readable - Add "alpha" to version to include pre-releases ActiveRecord: - 7.2: `Base.connection_pool.schema_migration.table_name` - 7.1, 7.0, 6.x: `Base.connection.schema_migration.table_name` - 5.x: `SchemaMigration.table_name` Close DatabaseCleaner#106
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I was submitting a PR related to improve the CI by fixing SQL dependency, run against latest stable Rails and Ruby version, run experimental versions against Rails edge and Ruby head, and I've noticed that the 7.1 file is using rails-edge
Ref: https://github.com/DatabaseCleaner/database_cleaner-active_record/actions/runs/9441466205/job/26002219838#step:4:714
database_cleaner-active_record/gemfiles/rails_7.1.gemfile
Line 6 in 0b0bfc4
So this leads to a false positive, because when testing against 7.1 stable the CI fails
Ref: https://github.com/tagliala/database_cleaner-active_record/actions/runs/9446754110
https://github.com/tagliala/database_cleaner-active_record/actions/runs/9446754110/job/26017081319#step:6:309
The text was updated successfully, but these errors were encountered: