Adds rails-7-1 support #78
Conversation
|
Would love to see this merged and released in a new version. Perhaps also with Ruby 3.2 added to the CI matrix. |
|
@eis-ioki You're going to want to add a Rails 7.1 gemfile and exclude the combination of Rails 7.1 with all Rubies earlier than Ruby 3.0. Plus you'll need to rebase to pick up the Ruby 3.2 addition to CI. |
| if Gem::Version.new("6.0.0") <= ::ActiveRecord.version | ||
| ::ActiveRecord::Base.connection.schema_migration.table_name | ||
| else | ||
| ::ActiveRecord::SchemaMigration.table_name |
There was a problem hiding this comment.
this no longer works in 7.1
please merge #82 instead
There was a problem hiding this comment.
That's what this PR is all about. You should use ::ActiveRecord::Base.connection.schema_migration.table_name from 6.0.0 onwards.
|
Finally got the whole matrix to pass which was difficult because of the different rubygems dependencies: https://github.com/eikes/database_cleaner-active_record/actions/runs/4194214954 |
There was a problem hiding this comment.
@eis-ioki This is great. Thanks for pushing this forward! 👍🏼
|
@etagwerker Is there going to be a gem release that includes this change published in the near future? That would be very helpful. |
In Rails 7.1 ::ActiveRecord::SchemaMigration.table_name is deprecated