helm: Add subcomponent labels for celery beat and worker at deployment #9865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
defectdojo.org/component: celery
defectdojo.org/subcomponent: worker
spec:
selector:
matchLabels:
defectdojo.org/component: celery
defectdojo.org/subcomponent: worker
template:
metadata:
labels:
defectdojo.org/component: celery
defectdojo.org/subcomponent: worker
```
1, The first label is for deployment itself, it gives label for that particular deployment.
2, The second label is selector: matchLabels which tells the resources(service etc) to match the pod according to label.
3. The third label is podTemplate labels, the template is actually podTemplate. It describe the pod that it is launched.
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Tip Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example... Powered by DryRun Security |
Signed-off-by: DefectDojo <defectdojo-project@owasp.org>
|
Closing and re-opening to re-kick the tests that didn't seem to run correctly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Signed-off-by: DefectDojo <defectdojo-project@owasp.org>
|
@mtesauro, Thank you. |
cneill
approved these changes
Apr 4, 2024
Maffooch
requested changes
Apr 8, 2024
Maffooch
approved these changes
Apr 8, 2024
|
@Maffooch, could you merge,please? |
|
@al-cheb PRs require 4 approvals from the reviewers before being merged. The only exception is library/module updates like dependabot and renovate. |
|
@dsever, hey, could you please review? |
hblankenship
approved these changes
Apr 30, 2024
dogboat
pushed a commit
to dogboat/django-DefectDojo
that referenced
this pull request
May 6, 2024
DefectDojo#9865) * helm: Add subcomponent labels for celery beat and worker at deployment ``` apiVersion: apps/v1 kind: Deployment metadata: labels: defectdojo.org/component: celery defectdojo.org/subcomponent: worker spec: selector: matchLabels: defectdojo.org/component: celery defectdojo.org/subcomponent: worker template: metadata: labels: defectdojo.org/component: celery defectdojo.org/subcomponent: worker ``` 1, The first label is for deployment itself, it gives label for that particular deployment. 2, The second label is selector: matchLabels which tells the resources(service etc) to match the pod according to label. 3. The third label is podTemplate labels, the template is actually podTemplate. It describe the pod that it is launched. * Update helm lock file Signed-off-by: DefectDojo <defectdojo-project@owasp.org> * bump chart version * Update helm lock file Signed-off-by: DefectDojo <defectdojo-project@owasp.org> * revert changes --------- Signed-off-by: DefectDojo <defectdojo-project@owasp.org> Co-authored-by: Alexander Chebotov <a.chebotov@arenadata.io> Co-authored-by: DefectDojo <defectdojo-project@owasp.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scope of this #9078 PR only the deployment label was added. To use pod affinity/antiaffinity for celery components a label should be added at
.spec.template.metadata.labelslevel.1, The first label is for deployment itself, it gives label for that particular deployment.
2. The second label is selector: matchLabels which tells the resources(service etc) to match the pod according to label.
3. The third label is podTemplate labels, the template is actually podTemplate. It describe the pod that it is launched.