[@types/three] Removing domElement optionality from OrbitControls constructor

[WORMSS]

domElement has not been optional since r110

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: Code
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@WORMSS Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• three — on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69107,
  "author": "WORMSS",
  "headCommitOid": "6e367738a06967133d5febbacdd1449f794a2b61",
  "mergeBaseOid": "88abfe7f1fca835cd7f7cbc8389f4b640c72ae43",
  "lastPushDate": "2024-03-21T23:06:11.000Z",
  "lastActivityDate": "2024-03-22T00:18:54.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "three",
      "kind": "edit",
      "files": [
        {
          "path": "types/three/examples/jsm/controls/OrbitControls.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "joshuaellis",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "Methuselah96",
      "date": "2024-03-22T00:18:54.000Z"
    }
  ],
  "mainBotCommentID": 2014010661,
  "ciResult": "pass"
}

[typescript-bot]

Hey @WORMSS,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @joshuaellis @Methuselah96 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[Methuselah96]

Thanks for the PR! The changes look good, do you mind creating the PR against https://github.com/three-types/three-ts-types instead? That is where we develop the three.js types.

[typescript-bot]

@WORMSS One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@WORMSS I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Apr 21st (in a week) if the issues aren't addressed.

[typescript-bot]

@WORMSS To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!