Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OrbitControls.d.ts - Removing domElement optionality #860

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Update OrbitControls.d.ts - Removing domElement optionality #860

merged 1 commit into from
Mar 22, 2024

Conversation

WORMSS
Copy link
Contributor

@WORMSS WORMSS commented Mar 22, 2024 •
edited
Loading

domElement has not been optional since r110

Code

Copying PR here at the request of @Methuselah96 Comment here

@WORMSS
Update OrbitControls.d.ts - Removing domElement optionality
b20375e 
domElement has not been optional since r110
Methuselah96
Methuselah96 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit 6cfe01e into three-types:master Mar 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WORMSS @Methuselah96