chore: added logic to deal with MultiPolygon geometries #94
Conversation
| ) | ||
| if isinstance(self.koswat_object.new_layer_surface, geometry.MultiPolygon): | ||
| _combined_xy = list( | ||
| map( |
There was a problem hiding this comment.
I don't understand how map() is used here. What is the iterable?
There was a problem hiding this comment.
Good o ne, I need to revise this.
There was a problem hiding this comment.
This should indeed be list(map(concatenate, zip(...))) however, I do not seem to find the failing test for which this piece of the code was required.
| zorder=1, | ||
| linestyle="solid", | ||
| ) | ||
| if isinstance(self.koswat_object.new_layer_surface, geometry.Polygon): |
There was a problem hiding this comment.
Shouldn't you test on the instance type of new_layer_geometry as new_layer_surface is (should be) a LineString?
There was a problem hiding this comment.
as far as I recall we store new_layer_geometry as a Polygon, not a LineString. I will have to check this again.
There was a problem hiding this comment.
Yes, this is a LineString, I think I had a failing test but I do not manage to find it, so I reverted all the added code here.
Co-authored-by: Ardt Klapwijk <59741981+ArdtK@users.noreply.github.com>
Carsopre
deleted the
fix/84-measures-not-calculated-when-there-is-a-multi-polygon-in-layers
branch
No description provided.