-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/83 removal of outside grass and clay layers with outside reinforcement #95
Merged
Carsopre
merged 8 commits into
master
from
fix/83-removal-of-outside-grass-and-clay-layers-with-outside-reinforcement
Oct 23, 2023
Merged
Fix/83 removal of outside grass and clay layers with outside reinforcement #95
Carsopre
merged 8 commits into
master
from
fix/83-removal-of-outside-grass-and-clay-layers-with-outside-reinforcement
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… related to how to determine layers geometries for a given reinforcement type.
This was
linked to
issues
Oct 19, 2023
1 unittest failed (glitch?) |
ArdtK
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions and questions added
docs/reference/koswat_docstrings/calculations/reinforcement_layers_wrapper.md
Outdated
Show resolved
Hide resolved
koswat/calculations/standard_reinforcement/standard_reinforcement_profile_builder.py
Show resolved
Hide resolved
…lygon-in-layers' into fix/83-removal-of-outside-grass-and-clay-layers-with-outside-reinforcement
Base automatically changed from
fix/84-measures-not-calculated-when-there-is-a-multi-polygon-in-layers
to
master
October 23, 2023 11:01
…ayers-with-outside-reinforcement
…ayers-with-outside-reinforcement
ArdtK
approved these changes
Oct 23, 2023
Carsopre
deleted the
fix/83-removal-of-outside-grass-and-clay-layers-with-outside-reinforcement
branch
October 23, 2023 13:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this PR needs to be merged AFTER #94