Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase PE # for 35day run #8

Conversation

jiandewang
Copy link

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@jiandewang
Copy link
Author

@DeniseWorthen I modified the two "35day" templates in order to speed up the runs, otherwise it won't be able to finish the 35-day runs

@DeniseWorthen
Copy link
Owner

@jiandewang This PR needs to be made to the P7a release branch

Also, the number of write tasks per group should be a multiple of 6. You have 88.

@jiandewang
Copy link
Author

@DeniseWorthen will merge to P7a. In the meantime I hope you can bring these changes in your upcoming PR so that develop branch will be updated. Adding extra 2 PE in write task won't impact the job, this will let fv3 uses exact 62 nodes.

@DeniseWorthen
Copy link
Owner

Neverless, as I understand it the write tasks are not load balanced when they are not a multiple of ntiles.

Two questions:

  1. what upcoming PR are you referring to ?
  2. the dt-atmos for P7a was the same as P6. Why are so many more tasks required? Or does this match the tasks that were actually used in P6 with the workflow?

@jiandewang
Copy link
Author

I mean ufs-community#584 which I believe is your upcoming PR. Current PE setting requires 20 min/day. The PE changes I made are exactly from P6.

@DeniseWorthen
Copy link
Owner

OK, I understand about the task numbers now.

We do want this PR to go to the P7a release branch I think. My PR will come until after several others (one is Moorthis so that may take a while). I can add it there too.

@jiandewang
Copy link
Author

I will get them to P7a branch first, while you can get them to develop branch later

@DeniseWorthen
Copy link
Owner

DeniseWorthen commented Jun 3, 2021

@jiandewang I've brought the P7a script changes into my CICE PR branch #610. Please make sure they look right.

@DeniseWorthen
Copy link
Owner

Changes will be committed in PR ufs-community#610

@jiandewang jiandewang deleted the feature/35d-add-PE branch June 13, 2021 04:10
DeniseWorthen added a commit that referenced this pull request Feb 22, 2023
…ces and turning off output; update FAQ documentation (was 1608); update drag suite intent mods (was 1612) (ufs-community#1597)

* update cdeps

* use fv3atm from PR 1612

* Changed UGWP diagnostic variable declaration intents from out to inout

* Docs/faqupdate (#8)

Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
Co-authored-by: jkbk2004 <jong.kim@noaa.gov>
Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants