Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-frac grid coupled tests #584

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented May 17, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

  • makes nems_frac the default CPLMODE and sets FRAC_GRID=true as the default
  • removes non-frac grid coupled regression tests; drops identifier "frac" from remaining test names
  • reduces wall clock for cpld_debugfrac. This test runs in about 5 mins but wall clock was set at 60mins.
  • reduce cpld_control_c384 to 12 hour forecast
  • removes non-v16 benchmark and non-frac 35d tests
  • comments out cpld_2threads test (Issue cpld_2threads test does not reproduce for fractional grid #622)
  • adds ktherm and tfrz_option for setting up mushy thermodynamics in CICE ice_in. The defaults are set to current values ktherm=1 and tfrz_option=linear_salt.

Issue(s) addressed

Testing

Pre-commit testing for gaea.intel shows that the following tests do not reproduce:

cpld_ca
cpld_satmedmf
cpld_decomp
cpld_2threads
cpld_control_wave

This is the expected result since these are the low-resolution tests which are currently running with non-frac grid. All other coupled tests pass the current develop branch comparison (develop-20210513).

A test baseline was created for the new suite of coupled tests for gaea.intel and all test passed against the test baseline.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?

  • None

JessicaMeixner-NOAA and others added 30 commits February 8, 2021 16:36
simplify some of the CMake and add future flexibility for gnu
This reverts commit 7b826d4.
 Conflicts:
	tests/fv3_conf/ccpp_gfdlmp_run.IN
	tests/fv3_conf/ccpp_multigases_run.IN
	tests/fv3_conf/cpld_bmark_run.IN
	tests/rt.conf
	tests/tests/fv3_gfdlmprad
	tests/tests/fv3_gfdlmprad_atmwav
DeniseWorthen and others added 9 commits June 2, 2021 15:44
*drop 'frac' from test names but temporarily retain comparison
against 'frac' baseline to confirm nothing broke
* revert changes to cntl_list; all expected tests pass against
old name
* make fixes in rt*conf files
* add optional variables to turn on mushy thermo
* add noahMPnsst suite to S2SW v16 compile
@DeniseWorthen
Copy link
Collaborator Author

Closed. Replacement PR #623 without wave update

DeniseWorthen added a commit that referenced this pull request Jun 8, 2021
* make nems_frac the default CPLMODE
* make FRAC_GRID=true the default
* remove non-frac grid regression tests
* change wall clock for debugfrac. This test runs in less than ~5mins
* remove additional cpld_bmark and wave tests and their 35d versions
* reduce fhmax control_c384 to 12 hours
* add optional variables to turn on mushy thermo
junwang-noaa added a commit that referenced this pull request Jun 8, 2021
…628)

* make nems_frac the default CPLMODE
* make FRAC_GRID=true the default
* remove non-frac grid regression tests
* change wall clock for debugfrac. This test runs in less than ~5mins
* remove additional cpld_bmark and wave tests and their 35d versions
* reduce fhmax control_c384 to 12 hours
* add optional variables to turn on mushy thermo

Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
@DeniseWorthen DeniseWorthen deleted the feature/remove_nonfrac_cpldtests branch June 9, 2021 12:37
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
…in branch to ufs-community/ccpp-physics ufs/dev branch (ufs-community#584)

* Officially changed the ccpp-physics pointer from NCAR/ccpp-physics main branch to ufs-community/ccpp-physics ufs/dev branch
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
This PR adds a Tutorial chapter to the SRW Documentation. There are descriptions for 5 severe weather events and a full tutorial for the first one (2019061518).
This PR also includes:

* Updates to the Glossary
* An introduction to SSH and scp data transfer, which will help users to download tutorial plots from HPC systems to their local system for viewing.
* Minor fixes/updates in other chapters for spelling/grammar/accuracy.

---------

Co-authored-by: gspetro <gillian.s.petro@gmail.com>
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert 4 existing cpld_control tests to fractional grid; drop existing non-frac RT tests for S2S, S2SW
3 participants