-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-frac grid coupled tests #584
Closed
DeniseWorthen
wants to merge
84
commits into
ufs-community:develop
from
DeniseWorthen:feature/remove_nonfrac_cpldtests
Closed
Remove non-frac grid coupled tests #584
DeniseWorthen
wants to merge
84
commits into
ufs-community:develop
from
DeniseWorthen:feature/remove_nonfrac_cpldtests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplify some of the CMake and add future flexibility for gnu
This reverts commit cea6fc6.
This reverts commit 7b826d4.
Conflicts: tests/fv3_conf/ccpp_gfdlmp_run.IN tests/fv3_conf/ccpp_multigases_run.IN tests/fv3_conf/cpld_bmark_run.IN tests/rt.conf tests/tests/fv3_gfdlmprad tests/tests/fv3_gfdlmprad_atmwav
the WW3 switch preprocessing routines
* the variable CCPP_SUITE needs to be quoted for GNU
13 tasks
*drop 'frac' from test names but temporarily retain comparison against 'frac' baseline to confirm nothing broke
* revert changes to cntl_list; all expected tests pass against old name * make fixes in rt*conf files
* add optional variables to turn on mushy thermo * add noahMPnsst suite to S2SW v16 compile
Closed. Replacement PR #623 without wave update |
DeniseWorthen
added a commit
that referenced
this pull request
Jun 8, 2021
* make nems_frac the default CPLMODE * make FRAC_GRID=true the default * remove non-frac grid regression tests * change wall clock for debugfrac. This test runs in less than ~5mins * remove additional cpld_bmark and wave tests and their 35d versions * reduce fhmax control_c384 to 12 hours * add optional variables to turn on mushy thermo
13 tasks
junwang-noaa
added a commit
that referenced
this pull request
Jun 8, 2021
…628) * make nems_frac the default CPLMODE * make FRAC_GRID=true the default * remove non-frac grid regression tests * change wall clock for debugfrac. This test runs in less than ~5mins * remove additional cpld_bmark and wave tests and their 35d versions * reduce fhmax control_c384 to 12 hours * add optional variables to turn on mushy thermo Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
pjpegion
pushed a commit
to NOAA-PSL/ufs-weather-model
that referenced
this pull request
Apr 4, 2023
…in branch to ufs-community/ccpp-physics ufs/dev branch (ufs-community#584) * Officially changed the ccpp-physics pointer from NCAR/ccpp-physics main branch to ufs-community/ccpp-physics ufs/dev branch
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
This PR adds a Tutorial chapter to the SRW Documentation. There are descriptions for 5 severe weather events and a full tutorial for the first one (2019061518). This PR also includes: * Updates to the Glossary * An introduction to SSH and scp data transfer, which will help users to download tutorial plots from HPC systems to their local system for viewing. * Minor fixes/updates in other chapters for spelling/grammar/accuracy. --------- Co-authored-by: gspetro <gillian.s.petro@gmail.com> Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Baseline Updates
Current baselines will be updated.
Waiting for Reviews
The PR is waiting for reviews from associated component PR's.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
nems_frac
the default CPLMODE and setsFRAC_GRID=true
as the defaultktherm
andtfrz_option
for setting up mushy thermodynamics in CICEice_in
. The defaults are set to current valuesktherm=1
andtfrz_option=linear_salt
.Issue(s) addressed
Testing
Pre-commit testing for gaea.intel shows that the following tests do not reproduce:
This is the expected result since these are the low-resolution tests which are currently running with non-frac grid. All other coupled tests pass the current develop branch comparison (develop-20210513).
A test baseline was created for the new suite of coupled tests for gaea.intel and all test passed against the test baseline.
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?