Remove non-frac grid coupled tests (Replacement PR, was #584) #623
Conversation
DeniseWorthen
requested review from
junwang-noaa,
JessicaMeixner-NOAA and
climbfuji
| #RUN | cpld_bmarkfrac_wave_v16_35d | | fv3 | | 2013040100 | ||
| #RUN | cpld_bmarkfrac_wave_v16_35d | | fv3 | | 2013070100 | ||
| #RUN | cpld_bmarkfrac_wave_v16_35d | | fv3 | | 2013100100 | ||
| #COMPILE | APP=S2SW SUITES=FV3_GFS_v16_coupled,FV3_GFS_v16_coupled_noahmp,FV3_GFS_v16_coupled_nsstNoahmp | + hera.intel orion.intel | fv3 | | |
There was a problem hiding this comment.
Maybe I missed this in the discussion today, why are these tests commented out and not removed?
There was a problem hiding this comment.
I retained them because we are still running the RT version of the benchmark v16 configuration (cpld_bmark_wave_v16).
|
Machine: orion |
|
No obvious reason why the 2 orion tests failed. I'll re-run them. |
* the following tests were re-run and passed Test 001 cpld_bmark_v16 PASS Test 002 cpld_restart_bmark_v16 PASS Test 003 datm_mx025_cfsr PASS
…628) * make nems_frac the default CPLMODE * make FRAC_GRID=true the default * remove non-frac grid regression tests * change wall clock for debugfrac. This test runs in less than ~5mins * remove additional cpld_bmark and wave tests and their 35d versions * reduce fhmax control_c384 to 12 hours * add optional variables to turn on mushy thermo Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
nems_fracthe default CPLMODEFRAC_GRID=trueas the defaultIssue(s) addressed
Testing
Pre-commit testing for gaea.intel shows that the following tests do not reproduce:
This is the expected result since these are the low-resolution tests which are currently running with non-frac grid. All other coupled tests pass the current develop branch comparison (develop-20210513).
A test baseline was created for the new suite of coupled tests for gaea.intel and all test passed against the test baseline.
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
None