Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/P7b: Bring in #623 with Mushy Thermodyn setting in RT #627

Closed

Conversation

junwang-noaa
Copy link
Collaborator

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

The PR brings in the code updates from #623 with Mushy Thermodyn setting in regression test, the changes are required for P7b for CICE6 update.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel

Dependencies

There is no dependency for this PR.

@junwang-noaa junwang-noaa changed the title Bring in #623 with Mushy Thermodyn setting in RT Release P7b: Bring in #623 with Mushy Thermodyn setting in RT Jun 8, 2021
@junwang-noaa junwang-noaa changed the title Release P7b: Bring in #623 with Mushy Thermodyn setting in RT Release/P7b: Bring in #623 with Mushy Thermodyn setting in RT Jun 8, 2021
@junwang-noaa
Copy link
Collaborator Author

The PR should go to P7b branch, not the develop branch

@junwang-noaa junwang-noaa deleted the mushy_setting branch November 24, 2021 14:52
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
…ation script (#627)

* Gaea hpc-stack location has changed to match that for the UFS-WM that results in all regression test passed successfully.
* Lmod initialization has been updated as well, similar to the one that worked for the UFS-WM to pass RTs. It is done by sourcing a single initialization script.

---------

Co-authored-by: Natalie Perlin <Natalie.Perlin@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant