Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support word order change, comma separation, Japanese for Excluding #604

Merged
merged 7 commits into from
Sep 29, 2023

Conversation

DenverCoder1
Copy link
Owner

@DenverCoder1 DenverCoder1 commented Sep 28, 2023

Description

  • Adds support for putting the days before or within the translation for Excluding {days}
  • Adds support for alternate comma separators ("، " for Arabic, Farsi, Urdu and "、" for Chinese, "・" for Japanese)
  • Adds support for overriding the day of week format to long names instead of short for specific locales
  • Adds Japanese translation for Excluding {days}

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

image

@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-support-co-qmdrhw September 28, 2023 19:12 Inactive
@DenverCoder1 DenverCoder1 mentioned this pull request Sep 28, 2023
13 tasks
@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-support-co-qmdrhw September 28, 2023 19:30 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-support-co-qmdrhw September 28, 2023 19:35 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-support-co-qmdrhw September 28, 2023 21:44 Inactive
@DenverCoder1 DenverCoder1 changed the title feat: Support word order change, comma separation, and day format for Excluding feat: Support word order change, comma separation, Japanese for Excluding Sep 28, 2023
@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-support-co-qmdrhw September 29, 2023 20:43 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-support-co-qmdrhw September 29, 2023 20:46 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-support-co-qmdrhw September 29, 2023 20:48 Inactive
@DenverCoder1 DenverCoder1 merged commit 061b1f0 into main Sep 29, 2023
2 checks passed
@DenverCoder1 DenverCoder1 deleted the support-comma-separator-and-day-format branch September 29, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant