Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated Korean for Excluding translation #607

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

FajarKim
Copy link
Contributor

@FajarKim FajarKim commented Oct 2, 2023

Description

Looking at the changes made in #604, it reminded me of the Korean translation for 'excluding.' Similar to Japanese, I modified the translation from the '제외된 날 {days}' to '{days} 제외된'. The use of '제외된' would make perfect sense when placed behind the day names. So, even without the word '날,' this sentence already makes sense, considering that before the significant change, we couldn't place '제외된' behind the day names.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

No screenshots

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, glad you were able to confirm that 👍

@DenverCoder1 DenverCoder1 merged commit d461943 into DenverCoder1:main Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants