Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item tooltips when item cannot be clicked for popup #7673

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

robojumper
Copy link
Member

@robojumper robojumper commented Jan 7, 2022

Based on @nev-r's fantastic suggestion in #7662. Most of the info and layout code is copied from the ItemFeed because the way it shows details applies really well here.
grafik
grafik

This adds item tooltips to items in ItemPicker (when adding item to loadout or pinning/excluding item in LO) and to the main inventory view when compare view is open.

@robojumper robojumper requested a review from nev-r January 7, 2022 11:37
@robojumper robojumper marked this pull request as draft January 7, 2022 11:37
@robojumper
Copy link
Member Author

Unresolved questions about the general design:

  • Should the tooltip instanciation be moved down to <InventoryItem>?
  • Where else do we need/want this tooltip? In theory the tooltip could also appear in the main inventory grid, vendors view etc.

@robojumper robojumper changed the title First iteration of Item Picker tooltips Item Picker tooltips Jan 7, 2022
@bhollis
Copy link
Contributor

bhollis commented Jan 7, 2022

I'm into it, but I had in mind two other changes that could possibly clash with this:

  1. Making long press open the item popup from these views
  2. Allowing toggle to a larger tile for items in these popups that looks more like the item feed's tiles.

@bhollis
Copy link
Contributor

bhollis commented Jan 7, 2022

We've also studiously avoided putting tooltips on the main inventory items because it can be annoying and overwhelming to have stuff pop up wherever your mouse is (the inventory grid is super dense).

@robojumper robojumper changed the title Item Picker tooltips Item tooltips when item cannot be clicked for popup Jan 7, 2022
@luislobo
Copy link

We've also studiously avoided putting tooltips on the main inventory items because it can be annoying and overwhelming to have stuff pop up wherever your mouse is (the inventory grid is super dense).

Yeah but it is really frustrating having to click on each weapon to see the perks. One big disadvantage of having to click the way it is today, is you cannot just go ahead and move from left to right and click over each weapon to glance perks because the pop up dialog adjusts depending on which "half of the screen you are" moving it to pop up on the left or right. Really annoying. If we had this popup you don't need to click and really becomes a breeze to quickly peak at the perks.

@Gix3612
Copy link
Contributor

Gix3612 commented Mar 14, 2023

I really like this but I completely agree that tooltips would get annoying when you don't want them there. Since mouseover is only a concern on desktop anyways, maybe you could use a modifier key to display them, e.g. hold Ctrl to show tooltips on hover.

@lowPolySkeleton
Copy link
Member

This continues to be a request from people and overall shortcoming of making loadouts from our dedicated loadouts page. It's easier to tell people to just not use the page specifically designed for loadouts, when making loadouts. might be worth a beta flag and let people test this or only implement these hovers in quick add sheets....

Of course the major issue with hovers is mobile... even if people know how to trigger a "hover" on mobile... your finger will be in the way of the info.

anyway just reviving this as it's still being asked in the discord with some frequency.

@bhollis
Copy link
Contributor

bhollis commented May 15, 2024

Trust me, I haven't forgotten about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants