Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Sketch up tiles for item picker #8248

Closed
wants to merge 1 commit into from
Closed

Conversation

bhollis
Copy link
Contributor

@bhollis bhollis commented Mar 27, 2022

I'm kind of torn over whether I'd want to make this an option, or just make it the default. Obviously the item density is way down, but the amount of info might make up for it. Thoughts?

Screen Shot 2022-03-26 at 6 36 43 PM

Screen Shot 2022-03-26 at 6 37 05 PM

@bhollis
Copy link
Contributor Author

bhollis commented Mar 27, 2022

Screen Shot 2022-03-26 at 6 41 08 PM

@nev-r
Copy link
Member

nev-r commented Mar 27, 2022

seems like an opportunity for #7673

@bhollis
Copy link
Contributor Author

bhollis commented Mar 27, 2022

I still don't terribly like info that's stuck behind hovers

@nev-r
Copy link
Member

nev-r commented Mar 27, 2022

armor view is unlovably busy but that's just one opinion

needs some colors or columns or spacing or all three, within the tile

@bhollis
Copy link
Contributor Author

bhollis commented Mar 27, 2022

Yeah agree, it's pretty hideous. Works on the item feed where there's only a single column.

@kyleshay
Copy link
Member

kyleshay commented Mar 28, 2022

Cells on the sheet looks great on mobile/single column!

  • Maybe on desktop the cells could be twice (or 1.5x, fit name and perks on one line) as wide, there is so much space to work with so the lower density may be ok?
    • Desktop also almost has enough space really for grouping the item types (sniper row, sidearm row, etc.)
  • Maybe a toggle at top of sheet to show/hide labels vs a preference in settings (for desktop only, mobile should just always show?)
  • Worth showing the icon for frame type (aggressive/lightweight/etc?) guessing not since no one memorizes that?

Also (though mostly unrelated) is the item sort on sheets the same as inventory?

@delphiactual delphiactual added Changelog-None Changelog not required and removed no changelog labels Apr 4, 2022
@bhollis bhollis marked this pull request as draft February 13, 2023 20:57
@bhollis bhollis closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog-None Changelog not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants