Restructure FFI #202
Merged
Restructure FFI #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBenoit
approved these changes
Jan 30, 2024
|
Finally, the CI is green |
|
Thank you! This time I’ll squash because there are intermediate commits which don’t pass the CI, so it’s not convenient for bisecting. |
TheBestTvarynka
added a commit
that referenced
this pull request
Feb 13, 2024
TheBestTvarynka
added a commit
that referenced
this pull request
Feb 14, 2024
CBenoit
pushed a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this pull request, I've restructured the FFI crate and moved common bindings to the
crates/ffi-typescrate.We plan to export SSPI and WinSCard functions from the one dll. So, I moved all SSPI-related bindings to the
sspimodule and placed the winscard functions definitions into thewinscardmodule.Also, I placed all winscard-related typings into a
ffi-typescrate. It'll help keep our code cleaner and reuse them when needed. Ideally, I think we should do the same with sspi: move sspi-related typing to this crate too.Most of the changes are just typings. So, don't be afraid of this big number 😅
Docs & references:
winscard.h