-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial winscard implementation and integration #210
Conversation
7f47493
to
41c6b2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s happening 🎉
Good job so far!!
EDIT: I reworded the last commits to follow the conventional commit specification
41c6b2e
to
7ff3d49
Compare
What commit specification do we follow? This one: https://www.conventionalcommits.org/en/v1.0.0/#specification? I just have a feeling I don't remember/know something and also I want to write good commit messages from the first try 😅 |
Correct!
Oh, some commits where just missing the type and the scope "smartcard" was not consistent. I just added the type and used the |
Hi,
In this pull request, I've implemented the smart card emulation in the form of the winscard crate and integrated it in the
ffi
andsspi
. So, now we can use an emulated smart card for the RDP authorization without additional drivers, TMP smart cards, etc.I've chosen the NIST.SP.800-73-4 as a specification to follow. So, our emulated smart is a PIV-compatible smart card.
More information you can read in those four pull requests description:
Known bugs:
This decryption error happens during the smart card logon too. Initial debugging and research were unsuccessful. Its fix will be provided in a separate pull request.
Docs & references:
winscard.h
cc @awakecoding