Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial winscard implementation and integration #210

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Conversation

TheBestTvarynka
Copy link
Collaborator

@TheBestTvarynka TheBestTvarynka commented Feb 14, 2024

Hi,
In this pull request, I've implemented the smart card emulation in the form of the winscard crate and integrated it in the ffi and sspi. So, now we can use an emulated smart card for the RDP authorization without additional drivers, TMP smart cards, etc.

I've chosen the NIST.SP.800-73-4 as a specification to follow. So, our emulated smart is a PIV-compatible smart card.

More information you can read in those four pull requests description:

Known bugs:

This decryption error happens during the smart card logon too. Initial debugging and research were unsuccessful. Its fix will be provided in a separate pull request.

Docs & references:

cc @awakecoding

@TheBestTvarynka TheBestTvarynka self-assigned this Feb 14, 2024
@TheBestTvarynka TheBestTvarynka marked this pull request as ready for review February 14, 2024 23:23
@CBenoit CBenoit enabled auto-merge (rebase) February 15, 2024 09:28
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s happening 🎉
Good job so far!!

EDIT: I reworded the last commits to follow the conventional commit specification

@CBenoit CBenoit merged commit 00f0fcc into master Feb 15, 2024
40 checks passed
@CBenoit CBenoit deleted the winscard-rs-impl branch February 15, 2024 09:43
@TheBestTvarynka
Copy link
Collaborator Author

EDIT: I reworded the last commits to follow the conventional commit specification

What commit specification do we follow? This one: https://www.conventionalcommits.org/en/v1.0.0/#specification?

I just have a feeling I don't remember/know something and also I want to write good commit messages from the first try 😅

@CBenoit
Copy link
Member

CBenoit commented Feb 15, 2024

EDIT: I reworded the last commits to follow the conventional commit specification

What commit specification do we follow? This one: https://www.conventionalcommits.org/en/v1.0.0/#specification?

Correct!

I just have a feeling I don't remember/know something and also I want to write good commit messages from the first try 😅

Oh, some commits where just missing the type and the scope "smartcard" was not consistent. I just added the type and used the scard scope everywhere appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants