WinSCard FFI implementation #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed by mstsc functions
…ChangeA, SCardGetStatusChangeW
CBenoit
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Thank you! Well documented again. 👍
I left a few comments that you can address and merge yourself. (Since we are merging into a dev branch, I think you should have the permissions.)
note: The commit type as per conventional commit specification for refactoring is refactor instead refac. If you want to stick to the convention.
|
I answered the comments but didn't resolve them and left them to you. Maybe you will have any other questions |
Thank you! Everything is good! 🙆♂️ |
TheBestTvarynka
added a commit
that referenced
this pull request
Feb 13, 2024
TheBestTvarynka
added a commit
that referenced
this pull request
Feb 14, 2024
CBenoit
pushed a commit
that referenced
this pull request
Feb 15, 2024
CBenoit
pushed a commit
that referenced
this pull request
Feb 15, 2024
CBenoit
pushed a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request contains the WinSCard FFI implementation.
The WinSCard FFI is very tricky because Microsoft designed this API with complications. For example, during the smart card context deletion, we also need to free all allocated resources by this context (like smart card handles and buffers). For every dangerous/critical place, I added a comment about it.
I can't make this PR smaller 😞 . The smart card context and smart card handles are very coupled together, so I can't split this PR into two.
Docs & references:
winscard.h.