Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packaging): include *.yml files from tests #41

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jun 25, 2024

Fixes #40

@Diaoul
Copy link
Owner

Diaoul commented Jun 25, 2024

Thanks, do you know if there is a way to avoid using MANIFEST.in just for that and use some pyproject options?

@mgorny
Copy link
Contributor Author

mgorny commented Jun 25, 2024

I've digged through setuptools documentation, asked a knowledgeable person — and apparently not, there's no replacement for MANIFEST.in at this point.

I suppose you could use setuptools-scm, and then I think everything from the git repository would end up in sdist — but not sure if that's what you want.

@Diaoul
Copy link
Owner

Diaoul commented Jun 25, 2024

I went deep yesterday in how setuptools work and from what I understand, options to include or exclude are mostly related to the package itself (i.e. enzyme) and not tests.

I think this current PR needs tweaking though, I'm afraid it risks including tests/data which is populated with some XML when running tests. Will take a look this evening (CEST).

@mgorny
Copy link
Contributor Author

mgorny commented Jun 25, 2024

I can change it to list that one file, if you prefer. I've assumed no other .yml files should end up there.

@Diaoul Diaoul merged commit 34a7bda into Diaoul:main Jun 25, 2024
@Diaoul
Copy link
Owner

Diaoul commented Jun 25, 2024

Nevermind, it's actually .xml files that we download as test data 👍

@Diaoul
Copy link
Owner

Diaoul commented Jun 25, 2024

rm -fr dist/ build/ enzyme.egg-info/ enzyme-0.5.2 && python -m build -s && tar -xzvf dist/enzyme-0.5.2.tar.gz && eza -laT enzyme-0.5.2

image

@mgorny
Copy link
Contributor Author

mgorny commented Jun 26, 2024

Thanks!

@mgorny mgorny deleted the test-include branch June 26, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/parsers/ebml missing from sdist for 0.5.0
2 participants