Redesign homepage #488

waltersajtos · 2021-05-10T12:50:31Z

Description

Implementation of the new homepage designs

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I updated the changelog with an end-user readable description
I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

Go to the homepage
Check if all buttons redirect to the expected page
Check if everything looks good on all resolutions
Check if the modals open on the homepage and work as expected

Link to issue

Closes: #380

Search bar now gets results on keyup

…h bar. Urls now come from config files.

# Conflicts: # src/app/modules/home/highlight-slider/highlight-slider.component.ts # src/app/modules/home/home.module.ts

…nto feature/380-redesign-homepage

niraymak · 2021-05-15T13:31:40Z

Any changes made?

Noticed that one highlight was not showing properly in responsive view.

waltersajtos · 2021-05-15T14:32:54Z

Any changes made?

Noticed that one highlight was not showing properly in responsive view.

I only changed the highlight logic, no styling. @liekevdvoort was going to look at it iirc.

…n' into feature/403-autocomplete-searchresult-newhomepage

…hows on the homepage for now. Also limited search results to 5

…load in when the user is authenticated and when there are 2 or more recommendations to show

…t. Conditional rendering on home page based on authentication

… also show up if there is only 1 recommendation.

….com/DigitalExcellence/dex-frontend into feature/497-recommendations-homepage

…ndations-homepage

…tions-homepage Recommendations on homepage

…ing properly

niraymak

🥇

RubenFricke

Great! Well done 🎉

niraymak and others added 8 commits December 16, 2020 13:26

Extracted search bar to seperate component

2a1a16a

Search bar now gets results on keyup

added new search related files

ae72012

search service now gets baseurl from config

e33e24d

changed elastic url for development

6740c7f

ElasticSearch now results based on autocomplete while typing in searc…

67652fc

…h bar. Urls now come from config files.

refactored functionality after many backend refactors

a298893

added autocomplete model

f24d81e

Open project detail on homepage instead of redirecting to overview page

240470f

waltersajtos assigned waltersajtos and liekevdvoort May 10, 2021

waltersajtos assigned macfleury-2000 May 10, 2021

waltersajtos requested review from niraymak and RubenFricke May 10, 2021 12:51

waltersajtos and others added 5 commits May 10, 2021 14:52

Merge branch 'develop' into feature/380-redesign-homepage

9c31ff1

# Conflicts: # src/app/modules/home/highlight-slider/highlight-slider.component.ts # src/app/modules/home/home.module.ts

Merge branch 'develop' into feature/403-search-optimalization

f3d6e65

Add back old code :/

50c70af

Add back old code :/

c82973f

Merge remote-tracking branch 'origin/feature/380-redesign-homepage' i…

d65a9b9

…nto feature/380-redesign-homepage

RubenFricke changed the title ~~Open project detail on homepage instead of redirecting to overview page~~ Redesign homepage May 10, 2021

autocomplete search results are now shown

fc5d62e

niraymak and others added 7 commits May 17, 2021 10:58

search service now returns default results for testing purposes

509072d

Styling changes search input

3e56c12

Overlfow ellipsis

dcba774

merge with search branch based on old homepage

249be20

removed old homepage component

39519db

Merge remote-tracking branch 'origin/feature/403-search-optimalizatio…

7aeaf4b

…n' into feature/403-autocomplete-searchresult-newhomepage

added conditional rendering for searchbar. Searchbar in navbar only s…

4cc2c5d

…hows on the homepage for now. Also limited search results to 5

niraymak previously approved these changes May 27, 2021

View reviewed changes

niraymak and others added 3 commits May 27, 2021 21:23

added project recommendations to the home page. Recommendations only …

f6d6bd6

…load in when the user is authenticated and when there are 2 or more recommendations to show

forgot git add .

c6ee710

Merge develop into feature/380-redesign-homepage

eecae09

waltersajtos dismissed niraymak’s stale review via eecae09 May 28, 2021 08:58

liekevdvoort and others added 7 commits May 28, 2021 12:05

Font size change on mobile

7764f5e

higlight card change

d006097

updated styling of recommended projects

076978d

fixed error in searchbar, updated text above recommendations componen…

58527c5

…t. Conditional rendering on home page based on authentication

remove commented css

5ac6771

Resolved linter error

27ea29e

fix likes not showing up in recommendation cards. Recommendations now…

537af88

… also show up if there is only 1 recommendation.

waltersajtos requested a review from niraymak May 28, 2021 20:37

niraymak added 11 commits June 1, 2021 10:00

Merge branch 'develop' into feature/497-recommendations-homepage

cb270a0

Merge branch 'feature/497-recommendations-homepage' of https://github…

ac0b871

….com/DigitalExcellence/dex-frontend into feature/497-recommendations-homepage

Merge branch 'feature/380-redesign-homepage' into feature/497-recomme…

75cadf5

…ndations-homepage

removed duplicate css

d3a2d7f

Merge pull request #498 from DigitalExcellence/feature/497-recommenda…

305d2fc

…tions-homepage Recommendations on homepage

fix linting errors

4021133

Merge branch 'develop' into feature/380-redesign-homepage

5e47439

added missing .svg

097e902

added 8px more to the highlight description box as they were not show…

2aefc87

…ing properly

refactored changelog issue

0474f85

changed highlight description height to 57px

f0fd1c2

niraymak approved these changes Jun 2, 2021

View reviewed changes

RubenFricke approved these changes Jun 2, 2021

View reviewed changes

RubenFricke merged commit 9359056 into develop Jun 2, 2021

RubenFricke deleted the feature/380-redesign-homepage branch June 2, 2021 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redesign homepage #488

Redesign homepage #488

waltersajtos commented May 10, 2021

niraymak commented May 15, 2021 •

edited

Loading

waltersajtos commented May 15, 2021

niraymak left a comment

RubenFricke left a comment

Redesign homepage #488

Redesign homepage #488

Conversation

waltersajtos commented May 10, 2021

Description

Type of change

Checklist

Steps to Test or Reproduce

Link to issue

niraymak commented May 15, 2021 • edited Loading

waltersajtos commented May 15, 2021

niraymak left a comment

Choose a reason for hiding this comment

RubenFricke left a comment

Choose a reason for hiding this comment

niraymak commented May 15, 2021 •

edited

Loading