Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign homepage #488

Merged
merged 95 commits into from
Jun 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
2a1a16a
Extracted search bar to seperate component
niraymak Dec 16, 2020
ae72012
added new search related files
niraymak Dec 16, 2020
e33e24d
search service now gets baseurl from config
niraymak Dec 16, 2020
6740c7f
changed elastic url for development
niraymak Dec 16, 2020
67652fc
ElasticSearch now results based on autocomplete while typing in searc…
niraymak Dec 16, 2020
a298893
refactored functionality after many backend refactors
Apr 7, 2021
f24d81e
added autocomplete model
Apr 12, 2021
240470f
Open project detail on homepage instead of redirecting to overview page
waltersajtos May 10, 2021
9c31ff1
Merge branch 'develop' into feature/380-redesign-homepage
waltersajtos May 10, 2021
f3d6e65
Merge branch 'develop' into feature/403-search-optimalization
niraymak May 10, 2021
50c70af
Add back old code :/
waltersajtos May 10, 2021
c82973f
Add back old code :/
waltersajtos May 10, 2021
d65a9b9
Merge remote-tracking branch 'origin/feature/380-redesign-homepage' i…
waltersajtos May 10, 2021
fc5d62e
autocomplete search results are now shown
niraymak May 15, 2021
509072d
search service now returns default results for testing purposes
niraymak May 17, 2021
3e56c12
Styling changes search input
liekevdvoort May 17, 2021
dcba774
Overlfow ellipsis
liekevdvoort May 17, 2021
249be20
merge with search branch based on old homepage
niraymak May 17, 2021
39519db
removed old homepage component
niraymak May 17, 2021
7aeaf4b
Merge remote-tracking branch 'origin/feature/403-search-optimalizatio…
niraymak May 17, 2021
4cc2c5d
added conditional rendering for searchbar. Searchbar in navbar only s…
niraymak May 18, 2021
f5fb68c
Merge branch 'develop' into feature/403-autocomplete-searchresult-new…
niraymak May 18, 2021
1a241dc
Merge branch 'develop' into feature/403-autocomplete-searchresult-new…
niraymak May 18, 2021
2dc3ab0
updated changelog
niraymak May 18, 2021
38232dd
removed unnecessary elastic variables and updated version
niraymak May 18, 2021
2ad2447
modal opens op home page instead of redirect to project overview page…
niraymak May 18, 2021
24e3366
removed redundant code
niraymak May 19, 2021
24d4481
refactored modal utility
niraymak May 19, 2021
87ececf
Search bar in topnav styling v1
liekevdvoort May 20, 2021
ed96e85
Remove dropsahdow
liekevdvoort May 20, 2021
bd0b67c
fix nav other pages
liekevdvoort May 20, 2021
354462b
Position search bar at bottom on mobile
liekevdvoort May 20, 2021
09b7f60
Comment out placeholders
liekevdvoort May 20, 2021
2d2e461
Highlights bottom
liekevdvoort May 20, 2021
35083a9
Gap size
liekevdvoort May 20, 2021
92ccd4e
Mobile fixes
liekevdvoort May 20, 2021
65e5bb9
Logged in user in wrapper
RubenFricke May 20, 2021
806df3b
Highlight changes
liekevdvoort May 20, 2021
d129500
Higlight tweaks
liekevdvoort May 20, 2021
181591f
sizing tweaks and max width on highlights slider
liekevdvoort May 20, 2021
29bed3d
Big screen limits
liekevdvoort May 20, 2021
8339d84
smaller screen fixes
liekevdvoort May 20, 2021
55fbabb
minor tweak small screens
liekevdvoort May 20, 2021
4723ca6
Font weight bold
liekevdvoort May 20, 2021
24b1b42
Remove placeholders
liekevdvoort May 21, 2021
a1b8c52
Cleanup search service and fix api-config
waltersajtos May 21, 2021
8b9fabc
Fixed opening of detail modals
waltersajtos May 21, 2021
548add4
merge with 380 homepage redesign
niraymak May 24, 2021
2c63be8
Merge branch 'develop' into feature/380-redesign-homepage
niraymak May 24, 2021
3245e47
Add search icon back
liekevdvoort May 24, 2021
f4a2af4
Refactor api request to fix the render issue
waltersajtos May 24, 2021
e7bc51b
Fix linter issues
waltersajtos May 24, 2021
38ed235
Ignore http errors on autoComplete endpoint
waltersajtos May 24, 2021
3eda640
Make matched part bold
waltersajtos May 24, 2021
2f40672
Make matched part bold
waltersajtos May 24, 2021
fa6b85c
Merge remote-tracking branch 'origin/feature/403-autocomplete-searchr…
waltersajtos May 24, 2021
654564f
Refactor the code that highlights the matched text
waltersajtos May 24, 2021
11d7e04
Add comments to highlight code
waltersajtos May 24, 2021
8865efc
Placement text in higlight slider when there are no highlights
liekevdvoort May 26, 2021
07ee588
Merge pull request #491 from DigitalExcellence/feature/403-autocomple…
RubenFricke May 26, 2021
f6ae97f
Fix width when there are no cards
liekevdvoort May 26, 2021
4ec2aa4
Merge branch 'feature/380-redesign-homepage' of https://github.com/Di…
liekevdvoort May 26, 2021
60eb4d4
Align sign in right
liekevdvoort May 26, 2021
863cc69
Sonarcloud error fix
liekevdvoort May 26, 2021
a0db391
Updated package.json files
RubenFricke May 26, 2021
6bd16b1
Styling constrains higlight card
liekevdvoort May 26, 2021
e5cbfe6
linter fix 1
liekevdvoort May 26, 2021
a4fdc07
Sonarcloud fix dulpicate
liekevdvoort May 26, 2021
8c91be8
Converted grid to flex for highlighted cards
RubenFricke May 26, 2021
8b87e77
Add footer :)
waltersajtos May 27, 2021
5ca6162
update css of highlight cards to make the highlight descriptions fit …
niraymak May 27, 2021
a4b671b
updated the requirements for the highlight description to 50 to 100 c…
niraymak May 27, 2021
2a7cc68
Merge branch 'develop' into feature/380-redesign-homepage
waltersajtos May 27, 2021
ae3a351
Fix linter issues
waltersajtos May 27, 2021
f6d6bd6
added project recommendations to the home page. Recommendations only …
niraymak May 27, 2021
c6ee710
forgot git add .
niraymak May 27, 2021
eecae09
Merge develop into feature/380-redesign-homepage
waltersajtos May 28, 2021
7764f5e
Font size change on mobile
liekevdvoort May 28, 2021
d006097
higlight card change
liekevdvoort May 28, 2021
076978d
updated styling of recommended projects
niraymak May 28, 2021
58527c5
fixed error in searchbar, updated text above recommendations componen…
niraymak May 28, 2021
5ac6771
remove commented css
niraymak May 28, 2021
27ea29e
Resolved linter error
RubenFricke May 28, 2021
537af88
fix likes not showing up in recommendation cards. Recommendations now…
niraymak May 28, 2021
cb270a0
Merge branch 'develop' into feature/497-recommendations-homepage
niraymak Jun 1, 2021
ac0b871
Merge branch 'feature/497-recommendations-homepage' of https://github…
niraymak Jun 1, 2021
75cadf5
Merge branch 'feature/380-redesign-homepage' into feature/497-recomme…
niraymak Jun 1, 2021
d3a2d7f
removed duplicate css
niraymak Jun 1, 2021
305d2fc
Merge pull request #498 from DigitalExcellence/feature/497-recommenda…
niraymak Jun 2, 2021
4021133
fix linting errors
niraymak Jun 2, 2021
5e47439
Merge branch 'develop' into feature/380-redesign-homepage
niraymak Jun 2, 2021
097e902
added missing .svg
niraymak Jun 2, 2021
2aefc87
added 8px more to the highlight description box as they were not show…
niraymak Jun 2, 2021
0474f85
refactored changelog issue
niraymak Jun 2, 2021
f0fd1c2
changed highlight description height to 57px
niraymak Jun 2, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,13 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

### Added

- Added search bar inside navbar with autocomplete suggested results. - [#403](https://github.com/DigitalExcellence/dex-frontend/issues/403)
- Refactored the home page. [#380](https://github.com/DigitalExcellence/dex-frontend/issues/380)
- Added project recommendations on the home page. [#497](https://github.com/DigitalExcellence/dex-frontend/issues/497)

niraymak marked this conversation as resolved.
Show resolved Hide resolved
### Changed

- Clicking to the next step in the wizard step-header will now skip the step & removed orange progress bar - [#460](https://github.com/DigitalExcellence/dex-frontend/issues/460)
- Clicking to the next step in the wizard step-header will now skip the step & removed orange progress bar [#460](https://github.com/DigitalExcellence/dex-frontend/issues/460)
- Made Project URI optional - [#492](https://github.com/DigitalExcellence/dex-frontend/issues/492)

### Deprecated
Expand Down
2,275 changes: 1,207 additions & 1,068 deletions package-lock.json

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dex-frontend",
"version": "1.0.1-beta",
"version": "1.3.0-beta",
"scripts": {
"ng": "ng",
"config": "ts-node set-env.ts",
Expand All @@ -23,7 +23,7 @@
"@angular/platform-browser": "^9.1.13",
"@angular/platform-browser-dynamic": "^9.1.13",
"@angular/router": "^9.1.13",
"@fortawesome/fontawesome-free": "^5.15.2",
"@fortawesome/fontawesome-free": "^5.15.3",
"@ngx-lite/debounce-click": "^0.2.3",
"@sentry/browser": "^5.30.0",
"@webcomponents/webcomponentsjs": "^2.5.0",
Expand All @@ -35,31 +35,31 @@
"oidc-client": "~1.10.1",
"quill": "^1.3.7",
"quill-markdown-shortcuts": "0.0.10",
"rxjs": "^6.6.3",
"rxjs": "^6.6.7",
"showdown": "^1.9.1",
"tslib": "^1.14.1",
"zone.js": "^0.10.3"
},
"devDependencies": {
"@angular-devkit/build-angular": "^0.901.13",
"@angular/cli": "^9.1.13",
"@angular-devkit/build-angular": "^0.901.15",
"@angular/cli": "^9.1.15",
"@angular/compiler-cli": "^9.1.13",
"@angular/language-service": "^9.1.13",
"@types/jasmine": "^3.6.3",
"@types/jasminewd2": "~2.0.3",
"@types/node": "^12.19.15",
"@types/jasmine": "^3.7.4",
"@types/jasminewd2": "^2.0.9",
"@types/node": "^12.20.13",
"codelyzer": "^5.2.2",
"jasmine-core": "~3.5.0",
"jasmine-spec-reporter": "~4.2.1",
"karma": "^5.2.3",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage-istanbul-reporter": "~2.1.0",
"karma-jasmine": "~2.0.1",
"karma-jasmine-html-reporter": "^1.5.4",
"karma-jasmine-html-reporter": "^1.6.0",
"protractor": "^7.0.0",
"ts-node": "~8.3.0",
"tslint": "^6.1.3",
"tslint-microsoft-contrib": "^6.2.0",
"typescript": "~3.7.5"
"typescript": "^3.7.7"
}
}
10 changes: 5 additions & 5 deletions src/app/app-routing.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@
import { NgModule } from '@angular/core';
import { RouterModule, Routes } from '@angular/router';
import { AuthCallbackComponent } from './components/auth-callback/auth-callback.component';
import { HomeComponent } from './components/home/home.component';
import { NotFoundComponent } from './components/not-found/not-found.component';
import { PrivacyPolicyComponent } from './components/privacy-policy/privacy-policy.component';
import { MainComponent } from './modules/home/main/main.component';

const routes: Routes = [
{ path: '', redirectTo: '/home', pathMatch: 'full' },
{ path: 'home', component: HomeComponent },
{ path: 'privacy', component: PrivacyPolicyComponent },
{ path: 'auth-callback', component: AuthCallbackComponent },
{path: '', redirectTo: '/home', pathMatch: 'full'},
{path: 'home', component: MainComponent},
{path: 'privacy', component: PrivacyPolicyComponent},
{path: 'auth-callback', component: AuthCallbackComponent},
{
path: 'project',
loadChildren: () => import('./modules/project/project.module').then((m) => m.ProjectModule),
Expand Down
17 changes: 9 additions & 8 deletions src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,16 @@
* along with this program, in the LICENSE.md file in the root project directory.
* If not, see https://www.gnu.org/licenses/lgpl-3.0.txt
*/
import { HttpClientModule, HTTP_INTERCEPTORS } from '@angular/common/http';
import { NgModule, ErrorHandler } from '@angular/core';
import { HTTP_INTERCEPTORS, HttpClientModule } from '@angular/common/http';
import { ErrorHandler, NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { AppRoutingModule } from './app-routing.module';
import { AppComponent } from './app.component';
import { AppLayoutComponent } from './components/app-layout/app-layout.component';
import { AuthCallbackComponent } from './components/auth-callback/auth-callback.component';
import { FormsModule } from '@angular/forms';
import { HomeComponent } from './components/home/home.component';
import { TokenInterceptor } from './interceptors/auth.interceptor';
import { TopHighlightCardsComponent } from './modules/highlight/top-highlight-cards/top-highlight-cards.component';
import { SharedModule } from './modules/shared/shared.module';
import { BsDropdownModule } from 'ngx-bootstrap/dropdown';
import { FooterComponent } from './components/footer/footer.component';
Expand All @@ -37,23 +35,23 @@ import { ModalModule } from 'ngx-bootstrap/modal';
import { NotFoundComponent } from './components/not-found/not-found.component';
import { PrivacyPolicyComponent } from './components/privacy-policy/privacy-policy.component';
import { ModalDeleteGenericComponent } from './components/modals/modal-delete-generic/modal-delete-generic.component';
import { StripHtmlPipe } from './utils/striptags.pipe';
import { QuillModule } from 'ngx-quill';
import { HomeModule } from './modules/home/home.module';
import { SearchComponent } from './components/search/search.component';
import { ProjectModule } from './modules/project/project.module';


@NgModule({
declarations: [
AppComponent,
AppLayoutComponent,
HomeComponent,
AuthCallbackComponent,
TopHighlightCardsComponent,
AlertComponent,
FooterComponent,
PrivacyPolicyComponent,
NotFoundComponent,
ModalDeleteGenericComponent,
StripHtmlPipe
SearchComponent
],
imports: [
BsDropdownModule.forRoot(),
Expand All @@ -66,6 +64,8 @@ import { QuillModule } from 'ngx-quill';
HttpClientModule,
SharedModule,
QuillModule.forRoot(),
HomeModule,
ProjectModule
],
providers: [
{
Expand All @@ -84,5 +84,6 @@ import { QuillModule } from 'ngx-quill';
}
],
bootstrap: [AppComponent],
exports: [SearchComponent]
})
export class AppModule { }
60 changes: 36 additions & 24 deletions src/app/components/app-layout/app-layout.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,44 +20,56 @@
<div class="main-container">
<header *ngIf="!displayContentWithoutLayout" class="header header-6 navbar navbar-expand-md navbar-light">
<div class="branding">
<span class="title"><a aria-label="Back to the Homepage" routerLink=""><img alt="" loading="lazy" src="assets/images/dex-logo-dark-orange.png"></a></span>
<span class="title"
><a aria-label="Back to the Homepage" routerLink=""><img alt="" loading="lazy" src="assets/images/dex-logo-dark-orange.png" /></a
></span>
<p (click)="onClickHeaderBetaText()" class="beta-text">Beta</p>
</div>

<button (click)="toggleNavbar()" class="navbar-toggler" type="button">
<span class="navbar-toggler-icon"></span>
</button>

<div [ngClass]="{ 'show': navbarOpen }" class="collapse navbar-collapse">
<div [ngClass]="{ show: navbarOpen }" class="collapse content navbar-collapse">
<div class="header-nav project-link">
<a (click)="onClickProjects()" class="nav-link nav-text" routerLinkActive="active">Projects</a>
<a class="nav-link nav-text" routerLink="project/add" routerLinkActive="active">Add project</a>
</div>
<div class="header-nav account">
<a *ngIf="!isAuthenticated" class="nav-link nav-text" routerLink="account/login" routerLinkActive="active">Sign
in</a>

<div *ngIf="this.showSearchbar" class="search-bar">
<app-search></app-search>
</div>
<div *ngIf="isAuthenticated" class="profile">
<div class="btn-group profile-dropdown w-100" dropdown>
<button aria-controls="dropdown-basic" class="btn dropdown-toggle profile-dropdown" dropdownToggle id="button-basic" type="button">
{{ name }} <img alt="" class="profile-picture" loading="lazy" src="assets/images/profile-placeholder.png"> <span class="caret"></span>
</button>
<ul *dropdownMenu aria-labelledby="button-basic" class="dropdown-menu" id="dropdown-basic" role="menu">
<li role="menuitem"><a (click)="onClickSignout()" class="dropdown-item" routerLinkActive="active">Sign
Out</a>
</li>
</ul>

<div *ngIf="!this.showSearchbar" class="search-bar"></div>
<div class="right">
<div class="header-nav account">
<a *ngIf="!isAuthenticated" class="nav-link nav-text" routerLink="account/login" routerLinkActive="active">Sign in</a>
</div>
<div *ngIf="isAuthenticated" class="profile">
<div class="btn-group profile-dropdown w-100" dropdown>
<button aria-controls="dropdown-basic" class="btn dropdown-toggle profile-dropdown" dropdownToggle id="button-basic" type="button">
{{ name }} <img alt="" class="profile-picture" loading="lazy" src="assets/images/profile-placeholder.png" />
<span class="caret"></span>
</button>
<ul *dropdownMenu aria-labelledby="button-basic" class="dropdown-menu" id="dropdown-basic" role="menu">
<li role="menuitem"><a (click)="onClickSignout()" class="dropdown-item" routerLinkActive="active">Sign Out</a></li>
</ul>
</div>
</div>
</div>
</div>

<div *ngIf="this.showSearchbar" class="search-bar-mobile">
<app-search></app-search>
</div>
</div>
</header>

<div *ngIf="displayBetaBanner" class="modal-beta-container">
<div class="modal-beta-content">
<p>DeX is a new platform and developed by students, it's still in <span class="accent-text-color">beta</span>. You
might encounter some bugs
or shortcomings. If you do, please do report them on our GitHub <a [href]="dexGithubIssueUrl">here</a></p>
<p>
DeX is a new platform and developed by students, it's still in <span class="accent-text-color">beta</span>. You might encounter some bugs or
shortcomings. If you do, please do report them on our GitHub <a [href]="dexGithubIssueUrl">here</a>
</p>
<button (click)="onClickCloseBetaMessage()" aria-label="Close Account Info Modal Box">&times;</button>
</div>
</div>
Expand All @@ -68,7 +80,6 @@
</a>
</div>


<div *ngIf="displayAlertContainer" class="alert-container">
<app-alert></app-alert>
</div>
Expand All @@ -79,11 +90,12 @@
</div>
</div>

<svg class='background' viewBox="0 0 355.4 374.9" xmlns="http://www.w3.org/2000/svg">
<polygon fill="#e85b3f" points="240.9 166 347.7 0 245.2 0 188.7 92.5 240.9 166"/>
<svg class="background" viewBox="0 0 355.4 374.9" xmlns="http://www.w3.org/2000/svg">
<polygon fill="#e85b3f" points="240.9 166 347.7 0 245.2 0 188.7 92.5 240.9 166" />
<polygon
fill="#1d1d1b"
points="230.9 181 215.8 159.8 112.1 0 5.3 0 122.1 185.3 0 374.9 108.3 374.9 176.7 258.7 246.2 374.9 355.4 374.9 230.9 181"/>
fill="#1d1d1b"
points="230.9 181 215.8 159.8 112.1 0 5.3 0 122.1 185.3 0 374.9 108.3 374.9 176.7 258.7 246.2 374.9 355.4 374.9 230.9 181"
/>
</svg>

<app-footer *ngIf="!displayContentWithoutLayout"></app-footer>
Expand Down
Loading